New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This check prevents fragment reconstruction for unreliable messages. Is this intentional? #9

Open

niuk opened this issue Dec 20, 2017 · 0 comments

niuk commented Dec 20, 2017

https://github.com/KillaMaaki/ReliableNetcode.NET/blob/c5a7339e2de70f52bfda2078f1bbdab2ec9a85c1/ReliableNetcode/Utils/IO/PacketIO.cs#L116-L117

The check here will fail if the channel ID written into the most significant two bits of the prefix byte at https://github.com/KillaMaaki/ReliableNetcode.NET/blob/c5a7339e2de70f52bfda2078f1bbdab2ec9a85c1/ReliableNetcode/ReliablePacketController.cs#L302 is anything other than Reliable. But when I changed the condition to allow any channel ID and sent dozens of unreliable greater-than-FragmentThreshold-sized messages per second, everything still seemed to work. Is there a reason that this feature is disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment