Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release builds should be added to github #12

Open
kylelutze opened this issue Jan 1, 2020 · 6 comments
Open

release builds should be added to github #12

kylelutze opened this issue Jan 1, 2020 · 6 comments
Labels
build Related to the build and release infrastructure enhancement New feature or request

Comments

@kylelutze
Copy link
Contributor

We should move all the release builds into the github release section.

@stephanemagnenat stephanemagnenat added build Related to the build and release infrastructure enhancement New feature or request labels Jan 2, 2022
@Shayan-To
Copy link

When will you add releases? Is there anywhere I can download binaries from? (I use Windows and Ubuntu.)

@stephanemagnenat
Copy link
Contributor

There are outdated binaries on the web site. For recent binaries, the ideal would be to have some form of continuous integration, creating builds that we can promote to releases. The problem is that this project is only very lightly maintained. There is no very active maintainer, when I have time I try to give it some love as the co-fonder of the project, but my bandwidth is very limited. So, if anyone can help setting up github CI to build binaries it would be very welcome!

@masoudd
Copy link

masoudd commented Oct 25, 2022

@stephanemagnenat Hi. I started working on this: https://github.com/masoudd/glob2/blob/master/.github/workflows/build.yml

The server won't build though. Fails with:

g++ -o build/src/glob2-server -g -Wall build/src/AINames.o build/src/BasePlayer.o build/src/BaseTeam.o build/src/BitArray.o build/src/GameHeader.o build/src/LANGameInformation.o build/src/LogFileManager.o build/src/MapHeader.o build/src/NetBroadcaster.o build/src/NetConnection.o build/src/NetConnectionThread.o build/src/NetConnectionThreadMessage.o build/src/NetGamePlayerManager.o build/src/NetListener.o build/src/NetMessage.o build/src/NetReteamingInformation.o build/src/NetTestSuite.o build/src/Order.o build/src/Race.o build/src/UnitType.o build/src/Utilities.o build/src/YOGConsts.o build/src/YOGGameInfo.o build/src/YOGGameResults.o build/src/YOGMessage.o build/src/YOGPlayerSessionInfo.o build/src/YOGPlayerStoredInfo.o build/src/BuildingUtils.o build/src/Bullet.o build/src/EntityType.o build/src/Glob2.o build/src/GlobalContainer.o build/src/Map.o build/src/MapThumbnail.o build/src/Sector.o build/src/Settings.o build/src/UnitUtils.o build/src/YOGAfterJoinGameInformation.o build/src/YOGDownloadableMapInfo.o build/src/WinningConditions.o build/src/YOGServerAdministratorCommands.o build/src/YOGServerAdministrator.o build/src/YOGServerAdministratorList.o build/src/YOGServerBannedIPListManager.o build/src/YOGServerChatChannel.o build/src/YOGServerChatChannelManager.o build/src/YOGServer.o build/src/YOGServerFileDistributationManager.o build/src/YOGServerFileDistributor.o build/src/YOGServerGame.o build/src/YOGServerGameLog.o build/src/YOGServerGameRouter.o build/src/YOGServerMapDatabank.o build/src/YOGServerPasswordRegistry.o build/src/YOGServerPlayer.o build/src/YOGServerPlayerScoreCalculator.o build/src/YOGServerPlayerStoredInfoManager.o build/src/YOGServerRouterAdministratorCommands.o build/src/YOGServerRouterAdministrator.o build/src/YOGServerRouter.o build/src/YOGServerRouterManager.o build/src/YOGServerRouterPlayer.o build/libgag/src/libgag_server.a -lz -lboost_thread -lboost_system -lpthread -lSDL2_net -lSDL2
/bin/ld: build/src/Settings.o: in function `Settings::load(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)':
/home/masoudd/code/glob2/src/Settings.cpp:129: undefined reference to `GAGGUI::Screen::scrollWheelEnabled'`

Here is the full log: http://ix.io/4e5x

See this failed run: https://github.com/masoudd/glob2/actions/runs/3320887140/jobs/5487810106

@Shayan-To
Copy link

I have a partially working version here.

For Ubuntu, it builds, but packaging does not work.

For Windows, I got stuck getting a build. I couldn't figure out how I should get the libraries for cross-compiling on Ubuntu. So I tried building on msys2 on Windows, and scons cannot find anything. I think it is looking for things in the wrong places. And for some reason, the behavior on GitHub actions is different from the behavior on my local machine.

(In fact, I was doing this some time ago, when some work came through and I forgot about it; until now that I saw the comment above!)

@stephanemagnenat
Copy link
Contributor

@Shayan-To could you make a draft PR rebased on latest master? That way people can easily try on their side?

@Shayan-To
Copy link

@stephanemagnenat I opened #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build and release infrastructure enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants