Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement contact feature in redux port #62

Closed
MatthewVita opened this issue Feb 3, 2017 · 3 comments
Closed

implement contact feature in redux port #62

MatthewVita opened this issue Feb 3, 2017 · 3 comments
Labels

Comments

@MatthewVita
Copy link
Member

No description provided.

@MatthewVita MatthewVita changed the title implement contact feature in Redux port implement contact feature in redux port Feb 3, 2017
@ghost ghost self-assigned this Feb 3, 2017
@ghost ghost added In Progress and removed Ready labels Feb 3, 2017
@ghost
Copy link

ghost commented Feb 3, 2017

  1. So in your mind is components/Patient.js the same as demographics/basic from the Angular app?
  2. If so, this would mean that alongside your component, I should create another dumb-presentational component for the emergency contacts.
  3. I probably will have to use a different container, although maybe we can use the same container if there is more overlap than we expect.
  4. I will post more questions later, but let's see what questions I have that still remain after further studying :)

@ghost
Copy link

ghost commented Feb 19, 2017

  1. The next question I think will be how to handle forms. This is the most popular form library with 5,000 stars: https://github.com/erikras/redux-form

  2. However, in the repo we forked from they don't even have a Redux Form library in their package.json so that might be unnecessary. I used that library a while ago but it was not the easiest thing.

  3. I think the having a form with just simple click handlers that fire off action creators would be fine and easier, however if you want some more of that advanced stuff like form error messages that only display after a field has been touched at least once and such that would be the way to go.

Sorry to outsource the decision to you all but you can make the best judgment about what would be helpful for Angular people :)

@MatthewVita
Copy link
Member Author

This is all done... I based my work off of your branch. Great base for me!

Here's a bug that came out of this impl though: #92

I've asked @ShaneChesnutt to work on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant