[Content] Hide any content except audiobooks/podcasts #77
Assignees
Labels
bug
Something isn't working
Comments
|
Hi! In the future, nothing except audiobooks and podcasts will be available because the app cannot handle e-books properly. Confirmed as a bug, thank you so much! |
GrakovNe
changed the title
|
Done in https://github.com/GrakovNe/lissen-android/releases/tag/1.1.19 How, any book/podcast without at least one [audio] chapter has been hidding from the search and library Lissen couldn't handle e-books neither now nor in the future, so shall we show it? |
|
This change have hidden all items on my setup except for one audio book. I've been trying to identify what makes that title different from my other audio books, but I see no logic too it so far. Looking at your commit I see you filter on I started to manually probe the API with curl, and no idea why the field is missing on some titles for me. Could we use another similar field as filter, like check length of It could be a bug in the AudioBookShelf API, but I don't immediately see the issue there or if it's by design. https://github.com/search?q=repo%3Aadvplyr%2Faudiobookshelf%20numAudioFiles&type=code P.S.: Also the "currently listening" view on top still show regular books when in progress, this view is not filtered (not very important). |
|
Thanks for the report numAudioFiles shall be required part of API according to https://api.audiobookshelf.org/#book API docs. but i see that's no field in your response. Could you provide the requests also that you did to servers? That's because numAudioFiles is mandatory field in minified response, but seems like you got extended ones i tried to hotfix the latest release: https://github.com/GrakovNe/lissen-android/releases/tag/1.1.22 it'll hide the only items which explicitly has zero items. If this field is ommited, the podcast or book shall be shown |
|
That change did not solve it for me unfortunately. Seems I used the wrong API endpoint, this was my request for the above response: I now see that it needs to be the "minified" library items according to the docs, so tried again with this: And now it does indeed return So I'm a bit at a loss why my library would only show 1 item now. It's quite a large collection (1210 items), maybe some kind of memory issue with the filtering or so?
Here is a screenshot (Big Magic is not an audio book). |
|
Seems like we have to research it deeply Could you try out this release: https://github.com/GrakovNe/lissen-android/releases/tag/1.1.28 I have completely reverted the changes about numTracks field and logic around it If it works, i have to re-think how to hide non-audio books from the list If not - well, i'd like to connect your server for a short time to inspect what really happens here |
|
This works, shows all entries in the library. 👍 Could it be pagination? I've programmed a similar bug in the past, if you filter client side and expect X items per page but you never get to page 2 as the filtered count is less, then the offset you request to the server is incorrect. |
|
this is good point. I have to research to to handle these case. Sent this release to GP and other stores, thank you a ton for the bug report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Quite a lot of content in my AudioBookShelf library are just epub and other ebook formats, not just audio books (AudioBookShelf is very versitile). When browsing it would be nice if there was a filter option on the three dots top right, to only list entries with audio book files.
The text was updated successfully, but these errors were encountered: