Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zkapp command hash regression test #1690

Closed
Isaac-DeFrain opened this issue Dec 23, 2024 · 1 comment · Fixed by #1718
Closed

Add zkapp command hash regression test #1690

Isaac-DeFrain opened this issue Dec 23, 2024 · 1 comment · Fixed by #1718
Assignees
@Isaac-DeFrain
Labels
Berkeley Bug Something isn't working properly Testing / QA
Milestone
Berkeley Support

Comments

@Isaac-DeFrain
Copy link
Member

I tried writing a regression test for zkapp command hashing, but ran into some errors I don't understand. The hashing is working locally in a unit test, so I'm happy with that!

The work is here which is on my branch feat/zkapp-command-hash-reg-test. Maybe @jhult can take this over the finish line.
@Isaac-DeFrain Isaac-DeFrain added Berkeley Bug Something isn't working properly Testing / QA labels Dec 23, 2024
@Isaac-DeFrain Isaac-DeFrain added this to the Berkeley Support milestone Dec 23, 2024
@Isaac-DeFrain Isaac-DeFrain moved this to Next in MinaSearch.com Dec 23, 2024
@Isaac-DeFrain Isaac-DeFrain assigned Isaac-DeFrain and unassigned jhult Jan 24, 2025
@Isaac-DeFrain
Copy link
Member Author

No longer required since we run ignored unit tests in tier 1

@github-project-automation github-project-automation bot moved this from Next to Done in MinaSearch.com Jan 24, 2025
@Isaac-DeFrain Isaac-DeFrain moved this from Done to In Progress in MinaSearch.com Jan 24, 2025
@Isaac-DeFrain Isaac-DeFrain moved this from In Progress to Done in MinaSearch.com Jan 24, 2025
@Isaac-DeFrain Isaac-DeFrain mentioned this issue Jan 24, 2025
Merged
4 tasks
@Isaac-DeFrain Isaac-DeFrain linked a pull request Jan 24, 2025 that will close this issue
test(tier1): run all ignored unit tests #1718
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Isaac-DeFrain Isaac-DeFrain

Labels
Berkeley Bug Something isn't working properly Testing / QA
Projects
MinaSearch.com
Status: Done
Milestone
Berkeley Support
Development

Successfully merging a pull request may close this issue.

test(tier1): run all ignored unit tests Isaac-DeFrain/mina-indexer
2 participants
@jhult @Isaac-DeFrain