-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using setState in externaly controlled custom callback #781
Comments
sum32
changed the title
External control callback setState
Using setState in externaly controlled custom callback
Dec 21, 2017
Open
I'm pretty sure your issues don't have anything to do with external state, but rather inconsistent prop/state handling that seems to have been introduced by #756. I'm trying to come up with a more specific repro. |
dahlbyk
added a commit
to dahlbyk/Griddle
that referenced
this issue
Dec 24, 2017
dahlbyk
added a commit
to dahlbyk/Griddle
that referenced
this issue
Dec 24, 2017
This should be fixed as of 1.11.1. |
Thanks!:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Griddle version
1.11.0
Expected Behavior
During extrenal control of Griddle through a react component it is possible to pass a callback function in Griddle properties(stories/index.tsx):
<Griddle extTrigger={this.extTrigger} data={fakeData} plugins={[LocalPlugin, LocalCustomPlugin]}>
This can then be obtain it in a Container component, like TableContainer(src/plugins/localCustomPlugin/components/TableBodyContainer.js):
Actual Behavior
The data should still show up in Griddle.
Steps to reproduce
Just load the story
and press
Griddle will break but the state variable in the external context will change as expected.
Pull request with failing test or storybook story with issue
#782
The text was updated successfully, but these errors were encountered: