Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature request: Show c, r, and d of an specific country against 5 other countries #7

Open
javierconcha opened this issue Apr 3, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@javierconcha
Copy link
Contributor

Hello Huidae,
I just saw your improved display of confirmed, recovered and death plots. It is looking very good. I was just talking about that feature with some of my users.

I am wondering if it is possible to display for instance always Chile, against the 5 countries with the most confirmed cases for comparison. I guess I would have to pull the data from those countries to have them locally, at least once per day.

Thanks!

@HuidaeCho
Copy link
Owner

Javier,

It is possible. However, my app is a global map and not specific to any country, so I'm not planning to implement features for a single country with multiple provinces at least in this repository. It's already slow and consumes a lot of memory. You can tweak my code to always plot Chile with other top countries.

Thanks,
Huidae

@HuidaeCho HuidaeCho added wontfix This will not be worked on and removed wontfix This will not be worked on labels Apr 3, 2020
@HuidaeCho
Copy link
Owner

HuidaeCho commented Apr 3, 2020

Maybe, it's better to copy index.html to country.html and implement this feature there so we can keep the code base cleanly separated. That's an idea if I implement it later. For now, it's a lower priority.

@HuidaeCho HuidaeCho added the enhancement New feature or request label Apr 3, 2020
@javierconcha
Copy link
Contributor Author

Sounds good! Thanks.

@javierconcha
Copy link
Contributor Author

I like the chile.html version, especially the new tabs. Thanks!
Two more things:

  1. A particular issue for Chile is that the authorities do not give the recovered by provinces, only for the whole country. Therefore, I will adapt the only showing CFR for the whole country.

  2. Some users have asked to have a tab for the comparison between Chile and for instance the USA, Italy, Spain, China. This would require to fetch the data once per day from these countries and keep them local, which is doable (e.g. from your repository), and plot them in an extra tab. However, I am not sure if it makes sense for my particular case since my idea is to show only Chile. I just put it here as a thought.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants