From 75f2705b99549fac564087523623a8fb13cf6a30 Mon Sep 17 00:00:00 2001 From: Philip Hackstock <20710924+phackstock@users.noreply.github.com> Date: Thu, 16 Jan 2025 09:09:08 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Daniel Huppmann --- docs/user_guide/config.rst | 2 +- .../data/region_processing/external_repo_test/nomenclature.yaml | 2 +- tests/test_region_aggregation.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/user_guide/config.rst b/docs/user_guide/config.rst index 744b3068..65ef0634 100644 --- a/docs/user_guide/config.rst +++ b/docs/user_guide/config.rst @@ -157,7 +157,7 @@ validation: Filter model mappings from external repositories ------------------------------------------------ -Since importing all model mappings from an external repository is typically not desired, +We often only want to use a subset of models in a particular project (and not import all mappings), so there is an option to filter for specific model mappings. This works very similarly to the filtering for definitions. diff --git a/tests/data/region_processing/external_repo_test/nomenclature.yaml b/tests/data/region_processing/external_repo_test/nomenclature.yaml index 155cbd81..aae2198a 100644 --- a/tests/data/region_processing/external_repo_test/nomenclature.yaml +++ b/tests/data/region_processing/external_repo_test/nomenclature.yaml @@ -14,4 +14,4 @@ mappings: repository: name: common-definitions include: - - MESSAGEix-GLOBIOM 2.1-M-R12 + - REMIND-MAgPIE 3.1-4.6 diff --git a/tests/test_region_aggregation.py b/tests/test_region_aggregation.py index 68c3cd5c..5640b71f 100644 --- a/tests/test_region_aggregation.py +++ b/tests/test_region_aggregation.py @@ -247,7 +247,7 @@ def test_mapping_from_external_repository(): TEST_FOLDER_REGION_PROCESSING / "external_repo_test" / "definitions" ), ) - assert {"MESSAGEix-GLOBIOM 2.1-M-R12"} == set(processor.mappings.keys()) + assert {"REMIND-MAgPIE 3.1-4.6"} == set(processor.mappings.keys()) finally: clean_up_external_repos(dsd.config.repositories)