From 0a23254bf738fa3878e278cb742ab2ec3e0b8a5c Mon Sep 17 00:00:00 2001 From: Keiran Raine Date: Tue, 15 Apr 2014 12:59:58 +0100 Subject: [PATCH] Missing dereference of value, oddly perl 5.10 spots this at compile time but newer perl doesn't --- lib/PCAP/Bwa/Meta.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PCAP/Bwa/Meta.pm b/lib/PCAP/Bwa/Meta.pm index 993429d..f0f7f6a 100644 --- a/lib/PCAP/Bwa/Meta.pm +++ b/lib/PCAP/Bwa/Meta.pm @@ -54,7 +54,7 @@ sub _init { my ($self, $opts) = @_; croak "'rg' is auto-populated, to initialise a start value see PCAP::Bwa::Meta::set_rg_index" if(exists $opts->{'rg'}); - for my $key(keys $opts) { + for my $key(keys %{$opts}) { croak "'$key' is not a valid parameter for object initialisation" unless(first {$key eq $_} @INIT_KEYS); croak "'$key' is not a scalar, only simple values are expected" if(ref $opts->{$key} ne q{}); $self->{$key} = $opts->{$key};