Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and themes to the presentation table dialog #9323

Open
rdstern opened this issue Dec 22, 2024 · 3 comments
Open

Add title and themes to the presentation table dialog #9323

rdstern opened this issue Dec 22, 2024 · 3 comments
Assignees

Comments

@rdstern
Copy link
Collaborator

rdstern commented Dec 22, 2024

@N-thony this should be easy to allocate, possibly either @derekagorhom or @MeSophie?

It is the Describe > Tables > Presentation dialog.

  1. Earlier @Patowhiz had the title (and footnote) on the main dialog. Could it be returned? (Just the main title, with footnote, and exactly as it is on the sub-dialog. Not the sub-title.
  2. Also the Select Theme from the Themes sub-dialog. It should be a checkbox, default unchecked, rather than a radio button. @Patowhiz would a checkbox also be ok - maybe even preferred also on the sub-dialog? Though there we would have to code that you don't tick both Select and Manual.
@Patowhiz
Copy link
Contributor

@rdstern

I believe the sub-dialog uses radio buttons to restrict the user to one of two options - not both. You can either select an existing theme or create a custom theme.

If you’d like to change the design and intention, I’m happy for that. It shouldn’t require significant underlying code changes.

@Fidel365
Copy link
Contributor

@rdstern happy to proceed with this once you give the greenlight .

@rdstern
Copy link
Collaborator Author

rdstern commented Dec 27, 2024

@Fidel365 you have the green light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants