Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the text find-replace dialog, also setting items to NA? #9326

Open
rdstern opened this issue Dec 30, 2024 · 0 comments
Open

Improve the text find-replace dialog, also setting items to NA? #9326

rdstern opened this issue Dec 30, 2024 · 0 comments
Assignees
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Dec 30, 2024

@lilyclements I suggest there are 2 items missing.
a) We don't have a good way here to set values as missing, i.e. NA. We actually do, but in our Replace dialog? The one item not yet in that code is to be able to ignore case in the string set into missing.
We could use the facility in the naniar package, but I wonder if our existing code is good enough that we could just add that element. I have an example, of station data from Zambia, that would be good to test.
b) We have nicely added the starts, end, contains commands into the rename dialog. Should they also be added into the Find/Replace dialog?

@rdstern rdstern added this to the 0.8.1 milestone Dec 30, 2024
@rdstern rdstern changed the title Improve the text find-replace dialog, and the setting items to NA? Improve the text find-replace dialog, also setting items to NA? Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants