From 9427fcd0e46c230288ff6003b6fb78e3647bbf5b Mon Sep 17 00:00:00 2001 From: Alexey Kuleshevich Date: Thu, 19 Dec 2024 20:18:47 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: teodanciu --- libs/cardano-ledger-core/CHANGELOG.md | 4 ++-- .../cardano-ledger-core/src/Cardano/Ledger/Crypto/Internal.hs | 2 +- libs/cardano-ledger-core/src/Cardano/Ledger/Hashes.hs | 2 +- libs/cardano-ledger-core/src/Cardano/Ledger/Keys/Internal.hs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libs/cardano-ledger-core/CHANGELOG.md b/libs/cardano-ledger-core/CHANGELOG.md index e1989787f37..d78581492b5 100644 --- a/libs/cardano-ledger-core/CHANGELOG.md +++ b/libs/cardano-ledger-core/CHANGELOG.md @@ -13,8 +13,8 @@ * `SafeHash`, `SafeToHash`, `HashAnnotated`, `castSafeHash` and `extractHash`. * `KeyRoleVRF`, `VRFVerKeyHash`, `toVRFVerKeyHash`, `fromVRFVerKeyHash` * `GenDelegPair` and `GenDelegs` -* Re-export `KeyRole` from `Cardano.Ledger.Hashes`: -* Re-export some of the new additions to `Cardano.Ledger.Hashes` from `Cardano.Ledger.Core. +* Re-export `KeyRole` from `Cardano.Ledger.Hashes`. +* Re-export some of the new additions to `Cardano.Ledger.Hashes` from `Cardano.Ledger.Core`. * Remove `GenesisCredential` as unused. * Remove `HASH`, `ADDRHASH` and `DSIGN` type families out of `Crypto` type class and turn them into type synonyms for the exact algorithms previously being used in diff --git a/libs/cardano-ledger-core/src/Cardano/Ledger/Crypto/Internal.hs b/libs/cardano-ledger-core/src/Cardano/Ledger/Crypto/Internal.hs index 6232fd909a7..1a74a329e18 100644 --- a/libs/cardano-ledger-core/src/Cardano/Ledger/Crypto/Internal.hs +++ b/libs/cardano-ledger-core/src/Cardano/Ledger/Crypto/Internal.hs @@ -5,7 +5,7 @@ {-# OPTIONS_HADDOCK not-home #-} -- Contents of this module will be moved to `Cardano.Protocol.Crypto` at some point later --- whenever we are ready to remove derpecations +-- whenever we are ready to remove deprecations module Cardano.Ledger.Crypto.Internal ( Crypto (..), StandardCrypto, diff --git a/libs/cardano-ledger-core/src/Cardano/Ledger/Hashes.hs b/libs/cardano-ledger-core/src/Cardano/Ledger/Hashes.hs index 746bec60c05..ee526a3ec2d 100644 --- a/libs/cardano-ledger-core/src/Cardano/Ledger/Hashes.hs +++ b/libs/cardano-ledger-core/src/Cardano/Ledger/Hashes.hs @@ -300,7 +300,7 @@ newtype GenDelegs = GenDelegs -- original bytes is to use the type 'MemoBytes', although there are a few types that -- store their original bytes in other ways. In order to encourage the use of newtype over -- 'Cardano.Ledger.MemoBytes.MemoBytes' newtype defined as a 'MemoBytes', which would get --- the functionality of retaining bytes and derviging of 'SafeToHash' instance for free. +-- the functionality of retaining bytes and deriving of 'SafeToHash' instance for free. -- | A 'SafeHash' is a hash of something that is safe to hash. Such types store their own -- serialisation bytes. The prime example is @('MemoBytes' t)@, but other examples are diff --git a/libs/cardano-ledger-core/src/Cardano/Ledger/Keys/Internal.hs b/libs/cardano-ledger-core/src/Cardano/Ledger/Keys/Internal.hs index bc56f1bcc10..81a5e999085 100644 --- a/libs/cardano-ledger-core/src/Cardano/Ledger/Keys/Internal.hs +++ b/libs/cardano-ledger-core/src/Cardano/Ledger/Keys/Internal.hs @@ -51,7 +51,7 @@ import GHC.Generics (Generic) import NoThunks.Class (NoThunks (..)) import Quiet --- | Cryptographic saigning algorithm used on Cardano blockchain. +-- | Cryptographic signing algorithm used on Cardano blockchain. type DSIGN = DSIGN.Ed25519DSIGN -- | The role of a key.