Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new DecCBOR instances that will replace Annotator instances #4818

Open
lehins opened this issue Jan 6, 2025 · 0 comments · May be fixed by #4846
Open

Add new DecCBOR instances that will replace Annotator instances #4818

lehins opened this issue Jan 6, 2025 · 0 comments · May be fixed by #4846
Assignees
@teodanciu
Labels
💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Collaborator

lehins commented Jan 6, 2025

With the new approach added in #4733 we can now start replacing usage of Annotator. This ticket can be done in stages, but in a same PR:

  1. Adding DecCBOR instances for all the same types that use Annotator
  2. Added property tests that ensure that decoding of all the same types with usage of Annotator and without matches exactly.
@teodanciu teodanciu self-assigned this Jan 14, 2025
@teodanciu teodanciu linked a pull request Jan 21, 2025 that will close this issue
Draft
9 tasks
@lehins lehins added the 💳 technical-debt Issues related to technical debt we introduced label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodanciu teodanciu

Labels
💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Non-Annotator DecCBOR instances IntersectMBO/cardano-ledger
2 participants
@teodanciu @lehins