Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-java-format linter broken on super-linter v5 #18

Open
J-The-Fox opened this issue Nov 11, 2023 · 0 comments
Open

google-java-format linter broken on super-linter v5 #18

J-The-Fox opened this issue Nov 11, 2023 · 0 comments
Labels
bug Something isn't working external Deals with something externally that we can't control github-actions Relating to GitHub Actions help wanted Extra attention is needed java Issue relating to Java

Comments

@J-The-Fox
Copy link
Owner

J-The-Fox commented Nov 11, 2023

Overview

When updating super-linter to v5, the google-java-format linter now shows "errors" on most Java files.

The error that it shows is just the path to the file. This is both unhelpful and I think it's a false positive as the very same file is linted succsfully during checkstyle linter. So nothing is really wrong with the file. Yet it still errors it out

An example of the supposed "error" from the google-java-format linter:

2023-11-11 19:39:50 [INFO]   File:[/github/workspace/2023-2024/main-bot/src/main/java/frc/controllers/Xbox.java]
2023-11-11 19:39:51 [ERROR]   Found errors in [google-java-format] linter!
2023-11-11 19:39:51 [ERROR]   Error code: 1. Command output:
------
/github/workspace/2023-2024/main-bot/src/main/java/frc/controllers/Xbox.java
------

The checkstyle linter output:

2023-11-11 19:40:52 [INFO]   File:[/github/workspace/2023-2024/main-bot/src/main/java/frc/controllers/Xbox.java]
2023-11-11 19:40:54 [INFO]    - File:[Xbox.java] was linted with [checkstyle] successfully
2023-11-11 19:40:54 [INFO]      - Command output:
------
Starting audit...
Audit done.
------

What makes this even stranger is that it isn't every single file. There are a select few files that are fine but I have no idea why.
Example:

2023-11-11 19:40:21 [INFO]   ---------------------------
2023-11-11 19:40:21 [INFO]   File:[/github/workspace/Learning_Materials/Beginner_Level/Java/B2Operators.java]
2023-11-11 19:40:21 [INFO]    - File:[B2Operators.java] was linted with [google-java-format] successfully
2023-11-11 19:40:22 [INFO]   ---------------------------
2023-11-11 19:40:22 [INFO]   File:[/github/workspace/Learning_Materials/Beginner_Level/Java/B3IfElseStatement.java]
2023-11-11 19:40:23 [ERROR]   Found errors in [google-java-format] linter!
2023-11-11 19:40:23 [ERROR]   Error code: 1. Command output:
------
/github/workspace/Learning_Materials/Beginner_Level/Java/B3IfElseStatement.java
------

This is confusing me and makes me want to revert back to the v4 if the issue persists

@J-The-Fox J-The-Fox added bug Something isn't working help wanted Extra attention is needed java Issue relating to Java github-actions Relating to GitHub Actions labels Nov 11, 2023
@J-The-Fox J-The-Fox pinned this issue Nov 11, 2023
@J-The-Fox J-The-Fox added the external Deals with something externally that we can't control label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Deals with something externally that we can't control github-actions Relating to GitHub Actions help wanted Extra attention is needed java Issue relating to Java
Projects
None yet
Development

No branches or pull requests

1 participant