Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some comments #11

Open
migube opened this issue Oct 21, 2024 · 0 comments
Open

some comments #11

migube opened this issue Oct 21, 2024 · 0 comments

Comments

@migube
Copy link

migube commented Oct 21, 2024

hi JLDevops & tx for this code.

the dependency are not uptodate but after manualmly adding them it worked out for me. (do you plan to update it once?)
I tested the tool on French comics, but didn't have good results
atm I end up and get better results (still need to test) with
regex_pattern = re.compile(r"ISBN[0-9]+|ISBN:[0-9]+", re.IGNORECASE)
x = re.search(regex_pattern, data.replace('.','').replace('-','').replace('—','').replace(' ',''))

note that a -verbose option would be nice for debugging :) (I print data)
also deleting the temp tiff files would be nice :-p
and checking that the resulting ISBN has the correct nr of digits, else tell to manually check for errors?

tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant