-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcat relay services in test suite slow and complicated #1
Comments
To clarify a test case can fail when it should not. E.g. when run once, this scenario fails, but running a 2nd time succeeds. Added 'over "5" seconds' to tests to allow more time for IO to sync in the background as an ugly workaround.
|
Attempting work around with FIFO between containers, but the blocking read() on the FIFO in python is cumbersome to handle - so using a FIFO is probably as might be almost as much effort as doing a workaround for async socket input. |
To confirm the "quick fix" of having two netcat containers act as relay recipients and write to a shared docker volume has timing issues, and even waiting up to 15 seconds can sometimes fail (falsely) . Would be better to have the |
The current test suite relies on two containers running netcat and using a shared docker volume where the behave container searches for the logs in the volume
Due to disc IO caching writes, etc, a time delay between sending and event and searching for it is needed. And this might be unreliable. A more reliable solution would be to have behave itself listen on ports and receive network events directly. Unfortunately, only v1.2.6 has support for async patterns such as opening a network socket in the background, sending a network event, and then waiting on the reply.
When 1.2.6 becomes latest/stable, this improvement can be made.
The text was updated successfully, but these errors were encountered: