Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and consolidate IParameterExpression #32

Open
JSkimming opened this issue May 10, 2017 · 0 comments
Open

Refactor and consolidate IParameterExpression #32

JSkimming opened this issue May 10, 2017 · 0 comments
Assignees

Comments

@JSkimming
Copy link
Owner

Problem

There are two near identical implementations for retrieving injected dependencies, originally constructor dependencies, and lateley property dependecies.

The logic in both implementations encapsulates:

  • Finding the composition for a dependency.
  • Handling IEnumerable<> dependencies.
  • Throwing a CompositionException for missing dependencies.

I'm not sure a third implementation could arise, (though it's possible), but it's likely a broader set of collections add amplified types will be supported, e.g. arrays, List<>, IReadOnlyCollection<>, Func<>, Lazy<T> etc. Therefore consolidating this into a single implementation would be beneficial and DRY.

Proposal

Not sure yet, most likely an internal static helper method.

@JSkimming JSkimming self-assigned this May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant