Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pokemon.get_skills_modifier does not account for Expertise #755

Open
magroader opened this issue Feb 2, 2021 · 0 comments
Open

pokemon.get_skills_modifier does not account for Expertise #755

magroader opened this issue Feb 2, 2021 · 0 comments

Comments

@magroader
Copy link
Collaborator

If a Pokemon has a skill proficiency, and also takes a feat to grant that skill proficiency (Brawny, Perceptive, Acrobat, Quick-Fingered, Stealthy), the pokemon.get_skills function returns the skill with a " (e)" suffix.

This results in a skill that is not really a skill, and the current 1.13.9 version of the app crashes on this.

I have fixed the crash by ignoring skills that aren't "real", but the latest version of the code still has a problem - it will not show the skill modifier for this, e.g.:

  • Stealth (e)
  • Perception (5)

In addition, tapping on the skills list will undoubtedly show the wrong value.

Finally, pokemon like Arceus who are skilled in "All Skills" will not show expertise at all if they have such feats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant