Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Implement responsive images #18

Open
JeremieLitzler opened this issue Mar 7, 2018 · 0 comments
Open

Implement responsive images #18

JeremieLitzler opened this issue Mar 7, 2018 · 0 comments

Comments

@JeremieLitzler
Copy link
Owner

JeremieLitzler commented Mar 7, 2018 •
edited
Loading

Which sizes?

  • On the index page, it is a unique 128px wide image as the size varies not much from small smartphone to large desktop (based on the chosen layout).
  • On the restaurant page we have 3 sizes:
    • 360px (smartphone)
    • 480px (tablet, small desktop)
    • 800px for anything larger (original size).

Globally applied optimization

On all images, we will apply:

  • a quality of 70
  • use progressive
  • strip all metadata
WebDevJL pushed a commit that referenced this issue Mar 13, 2018
feat- cover responsive and accessibility issues
ce8f55e 
- implements the responsive images on the details page
- update the image url construction to be used everywhere
- enable keyboard pseudo-scrolling on reviews using links
- update the headings to be semantically correct

- improve search modal to be able to select several options

Covers: #24, #18, #20, #21 and #19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremieLitzler