Implementing focus on restaurant.html #21

JeremieLitzler · 2018-03-07T12:10:10Z

What's to improve?

Same thing about the map found on index page.
The restaurant with lots of reviews need something to scroll down and up with the arrow keys.

Checklist

Make the map easier to navigate through with a keyboard
Make the scrolling down and up with the arrow keys possible when there is more than 3 reviews.

- update the modal component to work properly - add skip-link to go to search Cover: #20, #21, #24

- all the modals meets the requirements of #24 - the code is reusable covers : #24, #20 and #21

- implements the responsive images on the details page - update the image url construction to be used everywhere - enable keyboard pseudo-scrolling on reviews using links - update the headings to be semantically correct - improve search modal to be able to select several options Covers: #24, #18, #20, #21 and #19

- All non-text contents provide text alternatives - Elements on the page use the appropriate semantic elements. For those elements in which a semantic element is not available, appropriate ARIA roles are defined. - Headings are used properly - Links have a href and title attributes. - Make sure all buttons text are descriptives enough (ex: Learn More or More isn't enough). - Semantic elements (header, nav, main, section, article, footer, ...) are used properly - Fix the focus on a long list of reviews Covers: #28, #19, #20, #21

WebDevJL pushed a commit that referenced this issue Mar 8, 2018

feat: implement first accessible point

e732c1a

- update the modal component to work properly - add skip-link to go to search Cover: #20, #21, #24

WebDevJL pushed a commit that referenced this issue Mar 9, 2018

feat- make the modals accessible

ffca6a3

- all the modals meets the requirements of #24 - the code is reusable covers : #24, #20 and #21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing focus on restaurant.html #21

Implementing focus on restaurant.html #21

JeremieLitzler commented Mar 7, 2018 •

edited

Loading

Implementing focus on restaurant.html #21

Implementing focus on restaurant.html #21

Comments

JeremieLitzler commented Mar 7, 2018 • edited Loading

What's to improve?

Checklist

JeremieLitzler commented Mar 7, 2018 •

edited

Loading