Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RO/RP-1 better #43

Open
2 of 10 tasks
JonnyOThan opened this issue Jan 26, 2024 · 2 comments
Open
2 of 10 tasks

Handle RO/RP-1 better #43

JonnyOThan opened this issue Jan 26, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request investigate Needs more information mod support Related to some other mod

Comments

@JonnyOThan
Copy link
Owner

JonnyOThan commented Jan 26, 2024 •
edited
Loading

I'm not very familiar with RP-1 so will probably need some external input. But at the very least, we should remove TweakScale support for things that don't work. For example you can scale engines but modifying the thrust etc is actually disabled, so it's pointless:

TweakScale/GameData/TweakScale/ScaleExponents.cfg

Line 169 in 1c0a645

-ignore = ModuleEngineConfigs

  • Disable scaling on ModuleEnginesConfigs
  • Disable scaling for KSPWheelBase
  • Many parts have incorrect node sizes (because of rescaling?)

Investigate:

  • ProceduralFairingAdapter
  • ProceduralFairingBase
  • ProceduralFairingSide
  • ModuleROTank
  • ModuleROSolar
  • ModuleRORCS
  • ModuleRealAntenna
@JonnyOThan JonnyOThan added enhancement New feature or request mod support Related to some other mod investigate Needs more information labels Jan 26, 2024
@JonnyOThan JonnyOThan changed the title Handle RP-1 better Handle RO/RP-1 better Jan 26, 2024
@JonnyOThan
Copy link
Owner Author

Looks like RO has some patches using KSPWheel that can scale landing legs and wheels - should disable TweakScale on parts with those modules as well.

JonnyOThan added a commit that referenced this issue Feb 4, 2024
@JonnyOThan
#43, partial: Ignore some RO modules
bdb4ea0 
-ModuleEnginesConfigs, KSPWheelBase
@JonnyOThan JonnyOThan added the bug Something isn't working label Feb 5, 2024
@JonnyOThan
Copy link
Owner Author

image

scaled procedural fairing not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request investigate Needs more information mod support Related to some other mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonnyOThan