Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning off the FPS/RAM counters seems to make performance worse #826

Open
JordanSantiagoYT opened this issue Dec 28, 2024 · 11 comments
Open
Assignees
Labels
bug Something isn't working to do This is a priority

Comments

@JordanSantiagoYT
Copy link
Owner

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!

apparently, TheTrueAccount2 has told me that the game actually performs worse if you turn off stuff related to the FPS counter.

the videos below showcase the worse performance between the options.

FPS and RAM counters both off:

2024-12-27.20-43-48.mp4

FPS only:

2024-12-27.20-34-44.mp4

FPS and RAM counter (only RAM usage):

2024-12-27.20-46-00.mp4

FPS and RAM counter (both RAM usage and RAM peak):

2024-12-27.20-47-43.mp4

i'm not sure what the cause for this is, but i am working on finding a fix for it (if possible.)

Command Prompt/Terminal/Crash logs (if existing)

None

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

run a spamchart and toggle the "FPS Counter", "Show RAM Usage" and "Show Max RAM Usage" options.

Are you modding a build from source or with Lua?

Lua

What is your build target?

Windows

Did you edit anything in this build? If so, mention or summarize your changes.

no

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?

No

Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.

Yes

@JordanSantiagoYT JordanSantiagoYT added bug Something isn't working to do This is a priority labels Dec 28, 2024
@JordanSantiagoYT JordanSantiagoYT self-assigned this Dec 28, 2024
@JordanSantiagoYT
Copy link
Owner Author

update: i appear to have fixed the worst porformance when turning off the FPS Counter entirely. RAM Usage has yet to be fixed

@StinkTheStinker
Copy link

maybe its because of the fact that it's updating the memory and fps every millisecond

i would just put a delay on the fps and memory update for, about 1 second

@moxie-coder
Copy link
Collaborator

maybe its because of the fact that it's updating the memory and fps every millisecond

i would just put a delay on the fps and memory update for, about 1 second

there already is an delay on them

@StinkTheStinker
Copy link

there is?

@moxie-coder
Copy link
Collaborator

there is?

there's literally been one a few months ago, and it got updated recently by d805b56

@StinkTheStinker
Copy link

oh

@SyncGit12
Copy link
Collaborator

SyncGit12 commented Dec 31, 2024

aight my experience:

i tried this and the performance was the same!
just 400 fps no stutters

javascript

maybe because i have a fucking radeon rx 7700 xt

@StinkTheStinker
Copy link

try making the counter's have a alpha value of zero when disabled, that could work

@moxie-coder
Copy link
Collaborator

moxie-coder commented Jan 4, 2025

try making the counter's have a alpha value of zero when disabled, that could work

wouldn’t have any effect since it’s still going to be updating in the background either way, it would have no impact

@SyncGit12
Copy link
Collaborator

yea

@JordanSantiagoYT
Copy link
Owner Author

try making the counter's have a alpha value of zero when disabled, that could work

fps counter would still be updated in the background, so..

@SyncGit12 SyncGit12 mentioned this issue Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to do This is a priority
Projects
None yet
Development

No branches or pull requests

4 participants