Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Raise code coverage above 11% #227

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 12, 2024 · 1 comment · Fixed by #228
Closed
3 tasks done

🛠 Tooling: Raise code coverage above 11% #227

JoshuaKGoldberg opened this issue Jan 12, 2024 · 1 comment · Fixed by #228
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This repo has 11% code coverage right now. Yeesh. That's an angry red badge. I'd like to raise that amount.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: tooling Managing the repository's maintenance type: cleanup Tech debt or other code/repository cleanups labels Jan 12, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 12, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 12, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 12, 2024
@JoshuaKGoldberg
test: added tests for data fetching (#228)
3533ed1 
## PR Checklist

- [x] Addresses an existing open issue: fixes #227
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/refined-saved-replies/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/refined-saved-replies/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Extracts and adds unit tests for data fetching helpers in
`content-script.ts`.

The rest of the file is mostly DOM creation, so it wasn't very unit
testable. Ah well.
@JoshuaKGoldberg
Copy link
Owner Author

#228 raises test coverage to about 25%. Which still isn't ideal, but given that raising it more would necessitate testing DOM interactions, I think this is as good as we can get for now.

#4 will likely significantly reduce the amount of code in the content script, which will further help unit test coverage numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: added tests for data fetching JoshuaKGoldberg/refined-saved-replies
1 participant
@JoshuaKGoldberg