From a50e21d00d0ebed523b1b40486f16a471d68b805 Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Thu, 24 Oct 2024 16:42:14 -0300 Subject: [PATCH 1/8] Moved CPU tests and benchmarks to juliaecosystem. Reduced timeout limits. --- .buildkite/runbenchmarks.yml | 12 ++++++------ .buildkite/runtests.yml | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.buildkite/runbenchmarks.yml b/.buildkite/runbenchmarks.yml index 8e619ac0e..6a0d6f4a0 100644 --- a/.buildkite/runbenchmarks.yml +++ b/.buildkite/runbenchmarks.yml @@ -25,11 +25,11 @@ steps: artifact_paths: - "benchmarks/results/*" agents: - queue: "benchmark" + queue: "juliaecosystem" env: BENCHMARK_GROUP: CPU JULIA_NUM_THREADS: "{{matrix.threads}}" - timeout_in_minutes: 120 + timeout_in_minutes: 10 - label: "AMDGPU: Run Benchmarks" plugins: @@ -57,7 +57,7 @@ steps: rocmgpu: "gfx1101" env: BENCHMARK_GROUP: AMDGPU - timeout_in_minutes: 120 + timeout_in_minutes: 30 - label: "CUDA: Run Benchmarks" plugins: @@ -85,7 +85,7 @@ steps: cuda: "*" env: BENCHMARK_GROUP: CUDA - timeout_in_minutes: 120 + timeout_in_minutes: 30 - label: "Metal: Run Benchmarks" plugins: @@ -113,7 +113,7 @@ steps: arch: "aarch64" env: BENCHMARK_GROUP: Metal - timeout_in_minutes: 120 + timeout_in_minutes: 30 - label: "oneAPI: Run Benchmarks" plugins: @@ -140,7 +140,7 @@ steps: intel: "*" env: BENCHMARK_GROUP: oneAPI - timeout_in_minutes: 120 + timeout_in_minutes: 30 - wait: ~ diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index c431802a2..c045b0bf9 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -29,8 +29,8 @@ steps: using Pkg Pkg.test("KomaMRICore"; coverage=true, julia_args=`--threads=auto`)' agents: - queue: "juliagpu" - timeout_in_minutes: 60 + queue: "juliaecosystem" + timeout_in_minutes: 10 - label: "AMDGPU: Run tests on v{{matrix.version}}" matrix: From 30c543cafd168eb13907b561826d2205b3245ca8 Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 17:23:37 -0300 Subject: [PATCH 2/8] Increased timeout slightly and arch --- .buildkite/runbenchmarks.yml | 3 ++- .buildkite/runtests.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.buildkite/runbenchmarks.yml b/.buildkite/runbenchmarks.yml index 6a0d6f4a0..c3f7c000d 100644 --- a/.buildkite/runbenchmarks.yml +++ b/.buildkite/runbenchmarks.yml @@ -25,11 +25,12 @@ steps: artifact_paths: - "benchmarks/results/*" agents: + arch: "aarch64" queue: "juliaecosystem" env: BENCHMARK_GROUP: CPU JULIA_NUM_THREADS: "{{matrix.threads}}" - timeout_in_minutes: 10 + timeout_in_minutes: 15 - label: "AMDGPU: Run Benchmarks" plugins: diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index c045b0bf9..2973a9afd 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -29,8 +29,9 @@ steps: using Pkg Pkg.test("KomaMRICore"; coverage=true, julia_args=`--threads=auto`)' agents: + arch: "aarch64" queue: "juliaecosystem" - timeout_in_minutes: 10 + timeout_in_minutes: 15 - label: "AMDGPU: Run tests on v{{matrix.version}}" matrix: From e8485540622324dc70b4ba485b6b33ae849fa923 Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 17:45:17 -0300 Subject: [PATCH 3/8] Remove CPU codecov, and slightly increased timeout again. --- .buildkite/runbenchmarks.yml | 2 +- .buildkite/runtests.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.buildkite/runbenchmarks.yml b/.buildkite/runbenchmarks.yml index c3f7c000d..1a9bddd57 100644 --- a/.buildkite/runbenchmarks.yml +++ b/.buildkite/runbenchmarks.yml @@ -30,7 +30,7 @@ steps: env: BENCHMARK_GROUP: CPU JULIA_NUM_THREADS: "{{matrix.threads}}" - timeout_in_minutes: 15 + timeout_in_minutes: 30 - label: "AMDGPU: Run Benchmarks" plugins: diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index 2973a9afd..c069371e2 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -27,11 +27,11 @@ steps: julia -e 'println("--- :julia: Running tests") using Pkg - Pkg.test("KomaMRICore"; coverage=true, julia_args=`--threads=auto`)' + Pkg.test("KomaMRICore"; julia_args=`--threads=auto`)' agents: arch: "aarch64" queue: "juliaecosystem" - timeout_in_minutes: 15 + timeout_in_minutes: 30 - label: "AMDGPU: Run tests on v{{matrix.version}}" matrix: From b7e6a0808bf7bd9ee6c1e75b61298f9f2a875ed6 Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 18:46:43 -0300 Subject: [PATCH 4/8] Remove CPU coverage plugin and specify threads --- .buildkite/runtests.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index c069371e2..bd85d01b8 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -10,13 +10,9 @@ steps: plugins: - JuliaCI/julia#v1: version: "{{matrix.version}}" - - JuliaCI/julia-coverage#v1: - codecov: true - dirs: - - KomaMRICore/src - - KomaMRICore/ext env: TEST_GROUP: $TEST_GROUP + JULIA_NUM_THREADS: "8" command: | julia -e 'println("--- :julia: Instantiating project") using Pkg @@ -27,7 +23,7 @@ steps: julia -e 'println("--- :julia: Running tests") using Pkg - Pkg.test("KomaMRICore"; julia_args=`--threads=auto`)' + Pkg.test("KomaMRICore"; julia_args=`--threads=8`)' agents: arch: "aarch64" queue: "juliaecosystem" From 23070fa2cd0b23b697f24ea32ce49004a36f1b21 Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 18:47:03 -0300 Subject: [PATCH 5/8] num_cpu = 4, based on Lux --- .buildkite/runbenchmarks.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.buildkite/runbenchmarks.yml b/.buildkite/runbenchmarks.yml index 1a9bddd57..4e52f95ce 100644 --- a/.buildkite/runbenchmarks.yml +++ b/.buildkite/runbenchmarks.yml @@ -27,6 +27,7 @@ steps: agents: arch: "aarch64" queue: "juliaecosystem" + num_cpus: "4" env: BENCHMARK_GROUP: CPU JULIA_NUM_THREADS: "{{matrix.threads}}" From bdb3b53afe6c5764ba2c6aeb426c9b40fb33db86 Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 19:08:57 -0300 Subject: [PATCH 6/8] Modify num threads and cpus --- .buildkite/runbenchmarks.yml | 2 +- .buildkite/runtests.yml | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.buildkite/runbenchmarks.yml b/.buildkite/runbenchmarks.yml index 4e52f95ce..0d62c8a4f 100644 --- a/.buildkite/runbenchmarks.yml +++ b/.buildkite/runbenchmarks.yml @@ -27,7 +27,7 @@ steps: agents: arch: "aarch64" queue: "juliaecosystem" - num_cpus: "4" + num_cpus: "8" env: BENCHMARK_GROUP: CPU JULIA_NUM_THREADS: "{{matrix.threads}}" diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index bd85d01b8..c8e60c80b 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -10,9 +10,6 @@ steps: plugins: - JuliaCI/julia#v1: version: "{{matrix.version}}" - env: - TEST_GROUP: $TEST_GROUP - JULIA_NUM_THREADS: "8" command: | julia -e 'println("--- :julia: Instantiating project") using Pkg @@ -27,6 +24,10 @@ steps: agents: arch: "aarch64" queue: "juliaecosystem" + num_cpus: "4" + env: + TEST_GROUP: $TEST_GROUP + JULIA_NUM_THREADS: "8" timeout_in_minutes: 30 - label: "AMDGPU: Run tests on v{{matrix.version}}" From 617cee685c794a83eb4969e56147d0cffd84d8cb Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 19:29:30 -0300 Subject: [PATCH 7/8] Decreased num threads cpu tests --- .buildkite/runtests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index c8e60c80b..75f8fd348 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -20,14 +20,14 @@ steps: julia -e 'println("--- :julia: Running tests") using Pkg - Pkg.test("KomaMRICore"; julia_args=`--threads=8`)' + Pkg.test("KomaMRICore"; julia_args=`--threads=4`)' agents: arch: "aarch64" queue: "juliaecosystem" num_cpus: "4" env: TEST_GROUP: $TEST_GROUP - JULIA_NUM_THREADS: "8" + JULIA_NUM_THREADS: "4" timeout_in_minutes: 30 - label: "AMDGPU: Run tests on v{{matrix.version}}" From bc639173ee4aa193f4399c3a3faf53eb6a582e3d Mon Sep 17 00:00:00 2001 From: Carlos Castillo Passi Date: Tue, 29 Oct 2024 19:41:52 -0300 Subject: [PATCH 8/8] Remove ; julia_args=`--threads=4` from CPU tests. --- .buildkite/runtests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index 75f8fd348..09f18ca23 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -20,7 +20,7 @@ steps: julia -e 'println("--- :julia: Running tests") using Pkg - Pkg.test("KomaMRICore"; julia_args=`--threads=4`)' + Pkg.test("KomaMRICore")' agents: arch: "aarch64" queue: "juliaecosystem"