Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error handling for broken pipe in getconnection #295

Closed
iamed2 opened this issue Sep 11, 2018 · 4 comments
Closed

No error handling for broken pipe in getconnection #295

iamed2 opened this issue Sep 11, 2018 · 4 comments

Comments

@iamed2
Copy link
Contributor

iamed2 commented Sep 11, 2018

Julia 0.6.4
HTTP.jl 0.6.14
MbedTLS.jl 0.5.12 -- Please specify versions

HTTP.jl/src/ConnectionRequest.jl

Line 38 in cd9f60b

io = getconnection(IOType, url.host, url.port; kw...)

Sometimes this call to getconnection throws a UVError/IOError "connect: broken pipe (EPIPE)" (e.g., invenia/CloudWatchLogs.jl#4).

As far as I know this will be the same in the latest Julia+HTTP version combo.

Wrapping this in HTTP.IOExtras.IOError would allow the retry code in AWSCore.jl to retry in this case. Is that something we can add+backport?
@quinnj
Copy link
Member

quinnj commented Sep 11, 2018

Sounds fine to me; submit a PR?

@iamed2 iamed2 mentioned this issue Sep 11, 2018
Merged
@samoconnor
Copy link
Contributor

I've backported this to release-0.6 as well.

@iamed2
Copy link
Contributor Author

iamed2 commented Sep 18, 2018

Thanks!! That's excellent!

@samoconnor
Copy link
Contributor

Also see #306, which would imply simultaneously changing AWSCore to be compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quinnj @iamed2 @samoconnor