Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README's FAQ to make the default settings more clear #36

Open
marklchaves opened this issue Jul 29, 2021 · 5 comments
Open

Comments

@marklchaves
Copy link
Contributor

Update the README's FAQ How do I setup this plugin? question so the default behavior is more clear.

Proposed changes

Logged in Users option

  1. The Choose which roles can see this link radio button is selected by default.

  2. If no roles are selected, all roles can see the menu item by default.

  3. Once a role is checked, then only checked roles can see the menu item.

The Choose which roles won't see this link is not selected by default. When this radio button is selected, these rules apply:

  1. If no roles are selected, all roles still have visibility to the menu item by default.

  2. Once a role is checked, then only checked roles won't see the menu item.

@danieliser
Copy link
Contributor

danieliser commented Jul 30, 2021

Would you also consider relabeling in the plugin itself?

@marklchaves
Copy link
Contributor Author

Hey @danieliser,

The plugin name works for me. Did you have any other names in mind?

BTW, I'm having fun with it on my test site. I'm going to add it on my live site next.

Thanks!

@danieliser
Copy link
Contributor

@marklchaves Should have been more specific, the labeling inside the plugin for those fields you are explaining or others. Do you see similar simplifications like we made in PM's interfaces you can suggest them here as well.

@marklchaves
Copy link
Contributor Author

Hey @danieliser,

Sorry. Yes. Absolutely. Today, I'll work on a PR for the README too.

Thanks!

@marklchaves
Copy link
Contributor Author

Created PR #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants