-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth out "getting started" in the README #33
Comments
I think that originally README was meant to be a little more of a developer documentation file. pre-built docker image for each tool, or one common docker image will be a part of the CI. If the docker image cannot be built the PR cannot be merged.
Well this depends entirely on the individual setup that the end-user would like to have. By default all of these tools can be used as Python scripts or through a provided Docker image. There won't be any specific requirements as we assume that this software should work on all systems. The only issue is to be able to test it effectively on different OS (I don't know if we can introduce that to the CI?) Currently all of the tests are dockerized. So we can either choose to try and support different OS, or assume that if the Docker is working then all of the tools will be working.
Agreed. Do you have any opinions on that? pip installable vs Docker?
Agreed. In the end all of these tools should be available through this repository which will be a base: https://github.com/Kaszanas/SC2Tools
Agreed. Each of the tools should have separate commands in this case. Finally, there should be one command (pipeline) that is able to reproduce the output in the form of a final dataset for people to use. All of the tools in this repository were build to assist with some task around preparing a dataset.
Adding to a release manually every time will be a pain. I think in this case there should be some other solution that would require minimal oversight.
Fully agreed. I'd even set on having one command that takes an input and produces an output that contains a final dataset that can be used with this: https://github.com/Kaszanas/SC2_Datasets FinallyWould you be able to contribute some of these solutions? Do we split these between ourselves? |
I meant that the Docker image should be pushed to some public repository from where the user can download it. I meant that in the README this should be the default option for using the Docker image (not building manually).
Things like "linux" or "docker" are also requirements, even when they are obvious ;) Testing under Windows and even macOS (including macOS on ARM) can be done with GitHub's runners: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners It just needs some configuration and testing...
Docker! :) :) :)
You don't have to add it to each release (but if you wanted to, you CAN automate it). Simply create manually a release named "example-data" or whatever and upload the dataset there. I do that in RiverBench dataset repositories, where each repo has a "source" release which stores some big source file; see for example: https://github.com/RiverBench/dataset-muziekweb/releases/tag/source In the end the Releases feature of GitHub is a nice wrapper around S3 and... you can still use it as S3 ;)
Some – yes, but I cannot oversee it. Please assign me a specific task and I'll do my best. |
Currently the README does not really describe "how to get started with this", but rather offers a comprehensive set of instructions for doing X, Y, Z, and so on. This requires the reader to FIRST read all of this, read the Makefile, understand the complex network of dependencies, get some datasets to process, etc., and THEN run it. This makes it hard for external users to quickly evaluate if the software works.
Here I'm proposing a set of improvements to the README that would make this much more streamlined and ensure that users can really "get started" easily.
wget
one-liner to fetch this data.The text was updated successfully, but these errors were encountered: