Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-push hooks #21

Open
Createdd opened this issue Jul 26, 2018 · 2 comments
Open

Add pre-push hooks #21

Createdd opened this issue Jul 26, 2018 · 2 comments
Labels
dev ops / ci 🤖 regarding dev ops and continous integration enhancement 🚀 New feature or request help wanted ✋ Extra attention is needed

Comments

@Createdd
Copy link
Member

Createdd commented Jul 26, 2018 •
edited
Loading

Add pre-push hook to check for:

  • linting
  • formatting
  • tests

Yes, this is done in Travis, but it's good to have immediate feedback before pushing bad code
@Createdd Createdd added enhancement 🚀 New feature or request dev ops / ci 🤖 regarding dev ops and continous integration labels Jul 26, 2018
@Createdd Createdd self-assigned this Jul 26, 2018
Createdd added a commit that referenced this issue Aug 5, 2018
@Createdd
#21 Example commit for test
8983cd1
@Createdd
Copy link
Member Author

Createdd commented Aug 5, 2018

Good article here: https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/

@Createdd
Copy link
Member Author

Createdd commented Aug 5, 2018 •
edited
Loading

Pushed a branch with the config: https://github.com/Keep-Current/web-miner/blob/feature/21_Add_pre_push_hooks/.pre-commit-config.yaml
But it's not working. Not quite sure why.

If someone else has done something similar feel free to take on that issue

@Createdd Createdd removed their assignment Aug 5, 2018
@Createdd Createdd added the help wanted ✋ Extra attention is needed label Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev ops / ci 🤖 regarding dev ops and continous integration enhancement 🚀 New feature or request help wanted ✋ Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Createdd