Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApp - Support Connect More Wallet #2032

Closed
saltict opened this issue Oct 17, 2023 · 1 comment · Fixed by #2064
Closed

WebApp - Support Connect More Wallet #2032

saltict opened this issue Oct 17, 2023 · 1 comment · Fixed by #2064
Assignees

Comments

@saltict
Copy link

saltict commented Oct 17, 2023

@saltict saltict changed the title WebApp - Support Connect Multiple Wallet WebApp - Support Connect More Wallet Oct 17, 2023
@Sokol142196 Sokol142196 added this to the Milestone 8 milestone Oct 21, 2023
@Sokol142196 Sokol142196 assigned saltict and unassigned S2kael Oct 23, 2023
@S2kael S2kael self-assigned this Oct 23, 2023
@S2kael S2kael linked a pull request Oct 23, 2023 that will close this issue
@Sokol142196
Copy link

Sokol142196 commented Oct 24, 2023

Version test: https://c5ff8660.subwallet-webapp.pages.dev/

Please check the issues:

  • Still shows EVM account even though disconnected extension successfully in case have only connected account

    • Reproduce with Talisman extension
    • Actual: Still show Talisman's EVM account in webapp, user must reload page to update account list
    • Expect: Back to Welcome screen after disconnected successful
  • Recheck bug Do not send token with account that connected Polkadot js extension
    Image


Confirm UX

  • Case: Disconnect extension

    • Actual: After disconnecting successfully then back to homepage
    • Expect: After disconnecting successfully then show the connect extension screen
  • Handle case forget site in extension --> Resolve later in Improve connect extension feature #1907

    • Actual: Still show connected status
      Image

    • Expect: Show disconnect status

  • Case: Do not have account in wallet (Talisman, Polkadot js) --> Resolve later in Improve connect extension feature #1907

    • Actual: Can not show wallet and do not show message to user
    • Expect: Show message to warn to user
      • Example:

Image

  • icon to distinguish connected extensions => require design

@hieudd hieudd modified the milestones: Milestone 8, Milestone 6 - WebApp Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants