Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension - Update message in case perform Liquid staking have XCM #3745

Closed
ThaoNguyen998 opened this issue Oct 3, 2024 · 4 comments · Fixed by #3800
Closed

Extension - Update message in case perform Liquid staking have XCM #3745

ThaoNguyen998 opened this issue Oct 3, 2024 · 4 comments · Fixed by #3800
Assignees
@tunghp2002
Milestone
Milestone 8

Comments

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Oct 3, 2024 •
edited
Loading

Describe the bug
Update message in case perform Liquid staking have XCM

To reproduce the bug
Steps:

  1. Perform liquid staking for Bifrost Polkadot
  2. Input Amount > Balance DOT (Bifrost Polkadot)
  3. Observe the Available balance the displayed screen

Actual:

Image

Expect: Update the maximum number that can be sent to avoid losing ED
@ThaoNguyen998 ThaoNguyen998 added this to the Milestone 8 milestone Oct 3, 2024
@tunghp2002 tunghp2002 linked a pull request Oct 23, 2024 that will close this issue
[Issue-3745] - Update message in case perform Liquid staking have XCM #3800
Merged
@ThaoNguyen998
Copy link
Author

ThaoNguyen998 commented Nov 9, 2024 •
edited by tunghp2002
Loading

Version test: http://14.224.129.242:8900/s/qNqmPK77SbSWZkN

  • Error message in case input Amount > transferable
    Actual:

    Image

    Expect:

    Image

@haiyenvu23
Copy link

Note for tester : Pls re-check issue #3930 on this pr

@haiyenvu23
Copy link

haiyenvu23 commented Dec 18, 2024 •
edited by tunghp2002
Loading

Version test : http://14.224.129.242:8900/s/8tELCis5WzTgpzd

  • Re-check message in case perform stake DOT(Acala)

    Image

    Image

@Sokol142196 Sokol142196 mentioned this issue Dec 27, 2024
Open
3 tasks
@haiyenvu23
Copy link

haiyenvu23 commented Dec 31, 2024 •
edited
Loading

Version test : http://localhost:8900/s/mBte4AGwLPkzcQJ
Validation passed in case :

  • Install/update version

  • Update message in case perform Liquid staking have XCM
    Image

  • Re-check some case validate when input amount
    Image
    Image
    Image

  • Re-check when stake other network type

@haiyenvu23 haiyenvu23 reopened this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tunghp2002 tunghp2002

Labels
None yet
Projects
None yet
Milestone
Milestone 8
Development

Successfully merging a pull request may close this issue.

[Issue-3745] - Update message in case perform Liquid staking have XCM Koniverse/SubWallet-Extension
3 participants
@ThaoNguyen998 @tunghp2002 @haiyenvu23