Fix guards OpenMP and GPU execution policy guards in signed_distance API #1192
Labels
App Integration
Issues related to integration with applications
bug
Something isn't working
Reviewed
User Request
Issues related to user requests
A user reported an error in how we handle execution policy guards in the signed distance API.
Specifically, we're using
#ifdef
in some cases but should actually be using#ifndef
guards.See #1191 for a proposed bugfix.
(Specifically, the changes to
signed_distance.cpp
)We might consider using this as an opportunity to clean up this section of the code.
Specifically, should the
SignedDistExec::OpenMP
enum case be defined in configurations that don't have OpenMP? Or would it be better to avoid this problem by eitherE.g. something like changing the enum definition from this
axom/src/axom/quest/interface/signed_distance.hpp
Lines 87 to 93 in 9ea7c93
to
isValid(SignedDistanceExec)
method that can better isolate the checksThis might depend on expectations about how users are using the
SignedDistanceExec
enum.The text was updated successfully, but these errors were encountered: