From 715c56272e6746a2621271a4c0c32e2cc981dc19 Mon Sep 17 00:00:00 2001 From: Steven Roberts Date: Fri, 17 Jan 2025 23:54:17 -0500 Subject: [PATCH 1/3] Apply suggestions from code review Co-authored-by: David Gardner --- .github/workflows/macos-latest.yml | 3 ++- .github/workflows/ubuntu-clang-latest.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/macos-latest.yml b/.github/workflows/macos-latest.yml index aacd531723..870e547127 100644 --- a/.github/workflows/macos-latest.yml +++ b/.github/workflows/macos-latest.yml @@ -35,7 +35,8 @@ jobs: - name: Build # Build your program with the given configuration - run: cmake \ + run: | + cmake \ --build ${{github.workspace}}/build \ --parallel $(sysctl -n hw.ncpu) \ --config ${{env.BUILD_TYPE}} diff --git a/.github/workflows/ubuntu-clang-latest.yml b/.github/workflows/ubuntu-clang-latest.yml index baf57aabb6..9fe8e1fd29 100644 --- a/.github/workflows/ubuntu-clang-latest.yml +++ b/.github/workflows/ubuntu-clang-latest.yml @@ -47,7 +47,8 @@ jobs: - name: Build # Build your program with the given configuration - run: cmake \ + run: | + cmake \ --build ${{github.workspace}}/build \ --parallel $(nproc) \ --config ${{env.BUILD_TYPE}} From 13b0dacd9376b30fb7a5fa2bdf466e86f8954d28 Mon Sep 17 00:00:00 2001 From: Steven Roberts Date: Fri, 17 Jan 2025 23:55:01 -0500 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: David Gardner --- .github/workflows/ubuntu-latest-oneapi.yml | 3 ++- .github/workflows/windows-latest-intel.yml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ubuntu-latest-oneapi.yml b/.github/workflows/ubuntu-latest-oneapi.yml index 7f653b9df1..06c13a33a8 100644 --- a/.github/workflows/ubuntu-latest-oneapi.yml +++ b/.github/workflows/ubuntu-latest-oneapi.yml @@ -42,7 +42,8 @@ jobs: -D ENABLE_SYCL=ON - name: Build - run: cmake \ + run: | + cmake \ --build ${{github.workspace}}/build \ --parallel $(nproc) \ --config ${{env.BUILD_TYPE}} diff --git a/.github/workflows/windows-latest-intel.yml b/.github/workflows/windows-latest-intel.yml index 3108b24032..7d84a3a3d3 100644 --- a/.github/workflows/windows-latest-intel.yml +++ b/.github/workflows/windows-latest-intel.yml @@ -43,7 +43,7 @@ jobs: run: cmake -G "Ninja" -B ${{github.workspace}}/build_shared -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_C_FLAGS=-Wno-deprecated-declarations -DCMAKE_C_COMPILER=icx-cl -DCMAKE_CXX_COMPILER=icx-cl -DCMAKE_Fortran_COMPILER=ifx -DBUILD_STATIC_LIBS=OFF -DBUILD_SHARED_LIBS=ON -DBUILD_FORTRAN_MODULE_INTERFACE=ON -DSUNDIALS_BUILD_WITH_PROFILING=ON -DSUNDIALS_TEST_ENABLE_UNIT_TESTS=OFF -DEXAMPLES_ENABLE_CXX=ON - name: Build (Shared) - run: q ${{github.workspace}}/build_shared --parallel $NUMBER_OF_PROCESSORS --verbose + run: cmake ${{github.workspace}}/build_shared --parallel $NUMBER_OF_PROCESSORS --verbose - name: Test (Shared) working-directory: ${{github.workspace}}/build_shared From 530f1d476f5f2e771bfcc2b615b58de050073f99 Mon Sep 17 00:00:00 2001 From: Steven Roberts Date: Sat, 18 Jan 2025 00:00:04 -0500 Subject: [PATCH 3/3] Update .github/workflows/windows-latest-intel.yml Co-authored-by: David Gardner --- .github/workflows/windows-latest-intel.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-latest-intel.yml b/.github/workflows/windows-latest-intel.yml index 7d84a3a3d3..610658bde3 100644 --- a/.github/workflows/windows-latest-intel.yml +++ b/.github/workflows/windows-latest-intel.yml @@ -43,7 +43,7 @@ jobs: run: cmake -G "Ninja" -B ${{github.workspace}}/build_shared -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_C_FLAGS=-Wno-deprecated-declarations -DCMAKE_C_COMPILER=icx-cl -DCMAKE_CXX_COMPILER=icx-cl -DCMAKE_Fortran_COMPILER=ifx -DBUILD_STATIC_LIBS=OFF -DBUILD_SHARED_LIBS=ON -DBUILD_FORTRAN_MODULE_INTERFACE=ON -DSUNDIALS_BUILD_WITH_PROFILING=ON -DSUNDIALS_TEST_ENABLE_UNIT_TESTS=OFF -DEXAMPLES_ENABLE_CXX=ON - name: Build (Shared) - run: cmake ${{github.workspace}}/build_shared --parallel $NUMBER_OF_PROCESSORS --verbose + run: cmake --build ${{github.workspace}}/build_shared --parallel $NUMBER_OF_PROCESSORS --verbose - name: Test (Shared) working-directory: ${{github.workspace}}/build_shared