got weird error output -- course not able to show using template.

[CSUF-CHUCK]

moodle version : 3.6.2+ (Build 20190208)
php version :
PHP 7.1.26 (cli) (built: Jan 11 2019 10:28:41) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.1.26, Copyright (c) 1999-2018, by Zend Technologies

With debug on, trying to create a course and the following error output was trapped.
moodledatadir/lock location is empty out.

I am able to verify the regex is correct. is there something I done wrong ? Thank you for your time looking.

Exception encountered in event observer '\local_course_template\observers::course_created': Coding error detected, it must be fixed by a programmer: A lock was created but not released at: /var/www/html/moodle/local/course_template/classes/observers.php on line 34 Code should look like: $factory = \core\lock\lock_config::get_lock_factory('type'); $lock = $factory->get_lock(Resource id #30); $lock->release(); // Locks must ALWAYS be released like this.

line 36 of /local/course_template/classes/observers.php: call to core\lock\lock->__destruct()
line ? of unknownfile: call to local_course_template\observers::course_created()
line 155 of /lib/classes/event/manager.php: call to call_user_func()
line 75 of /lib/classes/event/manager.php: call to core\event\manager::process_buffers()
line 834 of /lib/classes/event/base.php: call to core\event\manager::dispatch()
line 2466 of /course/lib.php: call to core\event\base->trigger()
line 162 of /course/edit.php: call to create_course()

[mackensen]

Usually a message like this means there was an unrelated failure, which then caused the lock to not be released. It's a symptom, not the cause. There's not much in the way of debugging statements inside classes/helper.php, but that's probably where the actual issue lies.

[CSUF-CHUCK]

the version I installed was .. .Local_course_template v2018051300
This is the same version which worked in moodle 3.4.
any pointer you can direct me to check ?

[mackensen]

That's the most recent version; it's been tested against Moodle 3.6 and should be fine.

[andyzito]

Hi CSUF-CHUCK, are you still experiencing this error?

[CSUF-CHUCK]

Yes ! Thank you for checking ! From: Andrew Zito [mailto:notifications@github.com] Sent: Friday, January 03, 2020 12:30 PM To: LafColITS/moodle-local_course_template <moodle-local_course_template@noreply.github.com> Cc: Yang, Charles <cyang@fullerton.edu>; Author <author@noreply.github.com> Subject: [External] Re: [LafColITS/moodle-local_course_template] got weird error output -- course not able to show using template. (#12) Hi CSUF-CHUCK, are you still experiencing this error? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__github.com_LafColITS_moodle-2Dlocal-5Fcourse-5Ftemplate_issues_12-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DALOPIOC4P4H4IOYQ227DO23Q36N5RA5CNFSM4G2NDPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICAO3I-23issuecomment-2D570689389%26d%3DDwMCaQ%26c%3DGlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw%26r%3DGc7vD8ikl-v4wABNg2cSIOaSaPDt9i8YGhBrB2uUqPE%26m%3DKskpfxdwNDADPSxcUGnSbmpjwodItuHGv6vWDhimZS0%26s%3D65vU2XUrqKOa_vjPRMQ4N5KE66LbEcMDafShaY1gx-I%26e%3D&data=02%7C01%7Ccyang%40fullerton.edu%7C7ae0aa28ab904c96190f08d7908bbf2d%7C82c0b871335f4b5c9ed0a4a23565a79b%7C0%7C0%7C637136802195564509&sdata=kfHPUl1w6VXSVrgWQUFbr8zcbkwJTVLpPEp7KKNHx%2FY%3D&reserved=0>, or unsubscribe<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__github.com_notifications_unsubscribe-2Dauth_ALOPIOCXUPBJ75GM6T6DZLDQ36N5RANCNFSM4G2NDPPA%26d%3DDwMCaQ%26c%3DGlhIK-Z7Itify6iax27XCf9KYFXDgbS2ET58kP-Ckgw%26r%3DGc7vD8ikl-v4wABNg2cSIOaSaPDt9i8YGhBrB2uUqPE%26m%3DKskpfxdwNDADPSxcUGnSbmpjwodItuHGv6vWDhimZS0%26s%3DpZD4KRQ9xxz2H80HFcdF5WJ18OaCLGik9cTXKNlY4w8%26e%3D&data=02%7C01%7Ccyang%40fullerton.edu%7C7ae0aa28ab904c96190f08d7908bbf2d%7C82c0b871335f4b5c9ed0a4a23565a79b%7C0%7C0%7C637136802195574505&sdata=KZfA%2FmCoZI2Zgq5mqkzTkhyg1Vxi63oKitUX8DOVQAE%3D&reserved=0>.

[andyzito]

Ok. I'll throw out some questions to try and troubleshoot more:

1. Are you using database locks or file locks? I believe DB locking is turned on with the following line in config.php: $CFG->lock_factory = '\\core\\lock\\db_record_lock_factory';

2. When you manually clear the locks, and then try to create a course from a template, does it fail, and what is the message? Can you observe the lock file/entry still in existence after this?

3. Are there any other warnings or error messages? As Charles rightly pointed out, the actual message you've posted is a symptom. The lock is failing to release because something else is going wrong in the creation of the template course and causing the whole process to die before the lock is released. If you have access to your code base you could insert some manual debugging statements in classes/helper.php inside the template_course function -- this is what the observer is ultimately calling, and where something has gone wrong that prevents the lock from being released.

[mackensen]

@CSUF-CHUCK we've just released a new version that may have addressed the issue you're experiencing.

[phette23]

Just FYI, we saw similar errors (messages about lock not being released tied into messages about fopen having too many open files) when we tested creating a large number (≈800) of courses with templates. When we did it live, I greatly increased the OS limit on open files (ulimit -Hn 50000; ulimit -Sn 50000; on Linux) before initiating the course creation and the problem didn't recur. We were also using caching on the production instance and not on our test server.

Example error:

Warning: fopen(...moodledata/temp/backup//28bb9178fbc2709cb14dc34c1b73df68.log): failed to open stream: Too many open files in ...moodle/backup/util/loggers/file_logger.class.php on line 45
++ Exception encountered in event observer '\local_course_template\observers::course_created': Coding error detected, it must be fixed by a programmer: A lock was created but not released at:
...moodle/local/course_template/classes/observers.php on line 48