Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot alter brightness past vanilla capabilities; Incompatibility with Alex's Caves #2

Open
DuffieShirayuki opened this issue Nov 3, 2023 · 2 comments

Comments

@DuffieShirayuki
Copy link

Brightness cannot be altered outside of the vanilla capabilities when played with Alex's Caves.

With Better Brightness Slider at -50% without Alex's Caves
2023-11-02_23 32 45

With Better Bightness Slider at -50% with Alex's Caves
2023-11-02_23 26 49

@MichaelMichelle2
Copy link

Brightness cannot be altered outside of the vanilla capabilities when played with Alex's Caves.

With Better Brightness Slider at -50% without Alex's Caves 2023-11-02_23 32 45

With Better Bightness Slider at -50% with Alex's Caves 2023-11-02_23 26 49

I am not apart of this mod, but I have got it working with Alex's Caves. You may need to change versions for Alex's caves or make sure ALL of its mods and core mods are updated. This worked for me when I added it to a preexisting pack I made.

@LaidBackSloth
Copy link
Owner

The reason for this is the Vanilla Darkness effect. When Mojang added it, they made sure that you can't have brightness lower as 0%, probably because it looks weird with the effect. In my mod I have just re-enabled that feature with a Mixin into the lightning engine, but when other mods change the lightning engine (like Alex's Caves does), it doesn't work anymore. I'm not sure if there is a good fix for this, but I'll look into it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants