Getting HP/MP drains to proc on AE items

[hooksta4]

#882

Moving discussion here from the issue.

I can't quite figure out how to get HP/MP AE to proc. There are two separate issues I am facing.

--INSERT INTO `item_mods` VALUES (18324,431,4);   -- Additional effect: MP_HEAL --Mjollnir 18324
--INSERT INTO `item_mods` VALUES (18324,499,18);  -- Additional effect animation (subEffect) xi.subEffect.MP_DRAIN
--INSERT INTO `item_mods` VALUES (18324,501,10);  -- Additional effect Chance 10%
--INSERT INTO `item_mods` VALUES (18324,952,16);   -- Additional effect Status Potency 16 (Max MP back)4-16

I just get 0 return on MP. Assumed that 952 (potency) would pull that but it constantly hits for 0.

---

for HP Drain I have the following:

--INSERT INTO `item_mods` VALUES (16777,431,5);   -- Additional effect: HP_DRAIN(Type HP_DRAIN)death_scythe 16777
--INSERT INTO `item_mods` VALUES (16777,499,21);  -- Additional effect animation (subEffect) xi.subEffect.HP_DRAIN
--INSERT INTO `item_mods` VALUES (16777,501,10);  -- Additional effect Chance 10%
--INSERT INTO `item_mods` VALUES (16777,952,10);   -- Additional effect Status Potency 10

This however throws errors on each swing.

Same with MP drain /Aspir knife

INSERT INTO `item_mods` VALUES (16509,431,6);   -- Additional effect: Aspir (Type DEBUFF)aspir_knife 16509
INSERT INTO `item_mods` VALUES (16509,499,22);   -- Additional effect animation (subEffect) xi.subEffect.Aspir
INSERT INTO `item_mods` VALUES (16509,501,10);  -- Additional effect Chance 10%
INSERT INTO `item_mods` VALUES (16509,952,3);   -- Additional effect Status Potency 3

Any advice would be much appreciated. Likely not referencing the proper new table somewhere. I would assume its in magic as drain_samba.lua one of the requires is magic.lua but honestly, cannot figure it out at this point.

Thanks!

[TeoTwawki]

the answer for both items was: damage was nil because a needed modifier was not set

---

for mjollnir:

I just get 0 return on MP. Assumed that 952 (potency) would pull that but it constantly hits for 0.

its not a status effect, so status potency does nothing.

xi.additionalEffect.attack = function(attacker, defender, baseAttackDamage, item)
    local addType = item:getMod(xi.mod.ITEM_ADDEFFECT_TYPE)
    local subEffect = item:getMod(xi.mod.ITEM_SUBEFFECT)
    local damage = item:getMod(xi.mod.ITEM_ADDEFFECT_DMG)

    elseif addType == procType.MP_HEAL then -- Mjollnir does this, it is not Aspir.
        local MP = damage
        -- Unknown what modifies this, using power directly for now
        msgID = xi.msg.basic.ADD_EFFECT_MP_HEAL
        attacker:addMP(MP)
        msgParam = MP

in the global itself you can see it uses the damage modifier as the mp

---

for drains:

This however throws errors on each swing.

and the errors are?

likely when magic global was refactored something relied on there got moved. I can't check right away : dayjob) but likely I need to update the requires.

[TeoTwawki]

please reply in-thread like this 👍

[hooksta4]

Ah I think I see what you mean now... for the MP I just need 4 entries
431
499
500
501

It would appear as I do not have mod 500 local damage = item:getMod(xi.mod.ITEM_ADDEFFECT_DMG) for any of them drains. Will try that out and see if it works thanks!

[TeoTwawki]

so dmg was nil, inspector Teo is closing this case.