[Custom] Spell targeting Issue

[AuroraFFXI]

Cures, Protects, Shells, ~nas, and Haste's cant be cast on PCs outside of a party or alliance on my server as an Anti-Power Leveling measure. After switching over from topaz, cures all of a sudden can't be cast on the caster either, but otherwise works as intended including monsters. Pro/Shell/~nas/Haste all work fine too, including self targeting. The code in charentity.cpp is the only code I've changed that I don't fully understand, I had help implementing this feature right before DSP died way back when.

Any help would be appreciated, I am at a loss. Code for the Anti-PL stuff is the link below.
https://github.com/Aurasplash/server/commit/e28133344a51e8f7de456120ddf9b855ae2025d7

Thanks

[claywar]

Does this issue occur with an unmodified version of the server? Else, there's not much we can do.

[Aurasplash]

Does this issue occur with an unmodified version of the server? Else, there's not much we can do.

The only changes on the branch is the commit above.

[TeoTwawki]

That didn't answer his question now does it matter. He wants to know if there is a problem in our codebase or just your fork of it with your changes.

While we try to support everyone's ability to do custom things, we can't make a habit of fixing everyone's custom things for them either. Hopefully Zach's posts have been a help to you in figuring out what you need edit.

[Aurasplash]

Aah, gotcha, The unmodified codebase perfectly works fine. Where is the appropriate place to ask for help with custom stuff?

[TeoTwawki]

The team mostly leaves it to the reddit discord, which I also hang out in along with many server owners. I happen to be very into custom stuff myself (both making and sharing it)

I don't get a lot of free time for it these days but if I see something a question I can answer there, I try to.

[zach2good]

At a glance this looks like it should work without the changes to the target flags, I'll take a closer look tomorrow

EDIT: Moved answer up to here from the replies:

cures all of a sudden can't be cast on the caster either

PInitiator != this
This means: The caster of the spell is not the target. Try removing this section altogether, for your goal you probably aren't concerned with someone casting on themselves.

[zach2good]

cures all of a sudden can't be cast on the caster either

PInitiator != this
This means: The caster of the spell is not the target. Try removing this section altogether, for your goal you probably aren't concerned with someone casting on themselves.

[zach2good]

Another way to handle this is to put your 'outside of party or alliance' checks in the onMagicCastCheck section in each of the spells luas

[Aurasplash]

cures all of a sudden can't be cast on the caster either

PInitiator != this
This means: The caster of the spell is not the target. Try removing this section altogether, for your goal you probably aren't concerned with someone casting on themselves.

This made it work as intended. Thank you for the help.

At a glance this looks like it should work without the changes to the target flags, I'll take a closer look tomorrow

Without the target changes to charentity.cpp and just the SQL target target changes, you would be unable to target alliance members. Retail has nothing that can target alliance members but not outside alliance members so it was never added to the project.