Sudden crash on Nizul Isle during random aggro of some mob's

[Themaxdelta]

hi everyone, I need help please regarding a sudden crash in nyzul (if you want I can post the 2 npc fixed to start nyzul and recognize the mercenary ranks) I have the error txt file but I can't understand where it goes in conflict, I write the error file here, thanks again!
xi_map.exe_25-8_18-37-53.log

[WinterSolstice8]

Try this patch

diff --git a/src/map/utils/battleutils.cpp b/src/map/utils/battleutils.cpp
index 46e15ede37..a456456870 100644
--- a/src/map/utils/battleutils.cpp
+++ b/src/map/utils/battleutils.cpp
@@ -2394,7 +2394,7 @@ namespace battleutils
      *                                                                       *
      ************************************************************************/
 
-    int32 TakeWeaponskillDamage(CCharEntity* PAttacker, CBattleEntity* PDefender, int32 damage, ATTACK_TYPE attackType, DAMAGE_TYPE damageType, uint8 slot,
+    int32 TakeWeaponskillDamage(CBattleEntity* PAttacker, CBattleEntity* PDefender, int32 damage, ATTACK_TYPE attackType, DAMAGE_TYPE damageType, uint8 slot,
                                 bool primary, float tpMultiplier, uint16 bonusTP, float targetTPMultiplier)
     {
         auto* weapon   = GetEntityWeapon(PAttacker, (SLOTTYPE)slot);
diff --git a/src/map/utils/battleutils.h b/src/map/utils/battleutils.h
index ffceaa6d76..7c767b79ee 100644
--- a/src/map/utils/battleutils.h
+++ b/src/map/utils/battleutils.h
@@ -158,7 +158,7 @@ namespace battleutils
     int32 TakePhysicalDamage(CBattleEntity* PAttacker, CBattleEntity* PDefender, PHYSICAL_ATTACK_TYPE physicalAttackType, int32 damage, bool isBlocked,
                              uint8 slot, uint16 tpMultiplier, CBattleEntity* taChar, bool giveTPtoVictim, bool giveTPtoAttacker, bool isCounter = false,
                              bool isCovered = false, CBattleEntity* POriginalTarget = nullptr);
-    int32 TakeWeaponskillDamage(CCharEntity* PAttacker, CBattleEntity* PDefender, int32 damage, ATTACK_TYPE attackType, DAMAGE_TYPE damageType, uint8 slot,
+    int32 TakeWeaponskillDamage(CBattleEntity* PAttacker, CBattleEntity* PDefender, int32 damage, ATTACK_TYPE attackType, DAMAGE_TYPE damageType, uint8 slot,
                                 bool primary, float tpMultiplier, uint16 bonusTP, float targetTPMultiplier);
     int32 TakeSkillchainDamage(CBattleEntity* PAttacker, CBattleEntity* PDefender, int32 lastSkillDamage, CBattleEntity* taChar);
     int32 TakeSpellDamage(CBattleEntity* PDefender, CCharEntity* PAttacker, CSpell* PSpell, int32 damage, ATTACK_TYPE attackType, DAMAGE_TYPE damageType);

[jmcmorris]

That line in the header needs to be a CBattleEntity* PAttacker (it is a pointer)

[Themaxdelta]

we're noticing now that without using trusts, xi map doesn't crash, we've been testing for 30 minutes, anyway I'll try what you wrote, thanks

[WinterSolstice8]

#6170 will fix this