DeclarationError: Undeclared identifier. on contracts/token/onft721/ONFT721.sol

[arRasoul]

i get DeclarationError: Undeclared identifier. for _isApprovedOrOwner and _exists functions on ONFT721.sol contract when trying to compile.

i think it is due to openzeppelin contracts change declered here : https://github.com/OpenZeppelin/openzeppelin-contracts/blob/149e1b79fecb9db32f732c8c9f05ac2d8fa97471/CHANGELOG.md?plain=1#L179

"#### More about ERC721

In the case of ERC721, the _update function does not include a from parameter, as the sender is implicitly the previous owner of the tokenId. The address of this previous owner is returned by the _update function, so it can be used for a posteriori checks. In addition to to and tokenId, a third parameter (auth) is present in this function. This parameter enabled an optional check that the caller/spender is approved to do the transfer. This check cannot be performed after the transfer (because the transfer resets the approval), and doing it before _update would require a duplicate call to _ownerOf.

In this logic of removing hidden SLOADs, the _isApprovedOrOwner function was removed in favor of a new _isAuthorized function. Overrides that used to target the _isApprovedOrOwner should now be performed on the _isAuthorized function. Calls to _isApprovedOrOwner that preceded a call to _transfer, _burn or _approve should be removed in favor of using the auth argument in _update and _approve. This is showcased in ERC721Burnable.burn and in ERC721Wrapper.withdrawTo.

The _exists function was removed. Calls to this function can be replaced by _ownerOf(tokenId) != address(0)."

[ryandgoulding]

Can you please provide the steps to reproduce this error? Additionally, please include the versions of yarn and node that you utilized. Thanks!

[arRasoul]

Hello, I used remix ide to compile my contract. As you can see in the screenshots, *I used the 0.8.20+commit.a1b79de6 compiler*, because the OpenZeppelin ERC721 (latest update version 5.0.0) require ^0.8.20. I think because OpenZeppelin removed the _isApprovedOrOwner and _exists functions in their latest ERC721 update, but these functions are called in the onft721 contract, the "DeclarationError: Undeclared identifier" error occurred. I solved my problem by going back and adding ERC721 version 4.9 to my contract.

…

On Wed, Oct 25, 2023 at 11:56 PM Ryan Goulding ***@***.***> wrote: Can you please provide the steps to reproduce this error? Additionally, please include the versions of yarn and node that you utilized. Thanks! — Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZR5WS4EY27WUR74SSSMO6TYBGRJHAVCNFSM6AAAAAA6HK6WDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQGIYTENZWGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ryandgoulding]

#118 tracks possibility of upgrade, closing this as a duplicate.