Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit image size for better web performance #10

Open
enys opened this issue Oct 28, 2021 · 2 comments
Open

Limit image size for better web performance #10

enys opened this issue Oct 28, 2021 · 2 comments
Assignees
@davidrapin
Labels
enhancement question

Comments

@enys
Copy link

enys commented Oct 28, 2021

Considering end users can provide very large images, would it make sense to implement an image resize, before or while copying the images to the final destination:

dokapi/src/classes/AbstractGenerator.js

Line 66 in 61a92c1

copyImages() {

A more complex option is to create several image size, serve the appropriate one inline and link to a larger one if needed.
@davidrapin
Copy link
Contributor

a couple of viable options:

@davidrapin
Copy link
Contributor

tracked via: https://linkurious.atlassian.net/browse/LKE-4802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidrapin davidrapin

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidrapin @enys