Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the NER utils function aggregate_entities and its use in the Recogniser #283

Open
thobson88 opened this issue Dec 18, 2024 · 0 comments
Open

Review the NER utils function aggregate_entities and its use in the Recogniser #283

thobson88 opened this issue Dec 18, 2024 · 0 comments

Comments

@thobson88
Copy link
Collaborator

As pointed out in a review comment on PR #282, this function modifies a list in place and returns the list, which is confusing.

Also, when the function is called (by the Recogniser) the predictions list appears to be intended to accumulate results over a for loop but is in fact overwritten on each iteration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thobson88