HDR does not revert to On State upon disconnect #3580
Comments
|
@lyndonguitar Please try this build as it will have some additional logs for the relevant parts |
thank you, what build should I try? |
|
Welp, brainfart on my end :D This FrogTheFrog#5 |
thanks, this is the full log. There seems to be an error involving the HDR state?
|
|
It's most likely a bug on Windows side as we are asking it directly... Could you also please enable verbose logging and give me the logs again. |
Try this log with verbose on. I did a quick HDR on - > connect -> HDR off -> disconnect -> HDR still off |
|
Yeah, it some sort of Windows or driver bug, OR new windows API needs to be used. I will try to integrate the new API just for you and we can check if that helps. Will have a new build for you tomorrow probably. |
big thank you for the help! I'll try it asap once available. |
|
One question, you did not complain about this for some time (before you first noticed the bug). Was it working correctly or did you not use this feature? |
I did not use the feature before, only the resolution change. But eventually I tried HDR auto-change, i didnt immediately notice that there was an issue, just continued using it. Eventually I started to notice that my HDR was getting turned off seemingly randomly (I would use the host monitor for days with HDR turned off because of this). I would turn it on, be fine, and then I would stumble upon it turned off again in which i didnt know why. Then when I checked deeper I found out that it was Sunshine that was turned it it off but not turning it back on. |
|
@lyndonguitar I've pushed the update so can grab the new build whenever you fancy it. |
Can verify with quick connect disconnect testing that it does properly turn off and on the HDR now. Uploading the Verbose logs that covers the event. Thank you so much for this I'm curious as to what changed? Was this a wide-spread issue? are you also experiencing this? or is it specific to certain configurations/setups? |
|
Around 7 months ago Windows introduced a new API that allows to query and change "advanced_color_info_2": Before you could only ask for this info in "advanced_color_info" (v1): What Anyways, what's changed now is that I use |
|
I'll need to cleanup/finalize everything and once it's done, I'll ask you to test it again plz. |
|
@lyndonguitar please test the latest build when you can to make sure it still works. |
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the latest beta/pre-release?
None
Describe the Bug
I am running into problems where a non-HDR client will turn off my HDR host as requested/expected, but upon full disconnect, it will not turn back on the HDR, but all other parameters (resolution+refresh rate) are reverted successfully.
Expected Behavior
Upon disconnect, HDR should be reverted to turned on state, if host has HDR on.
Additional Context
I reported it here before FrogTheFrog#2 (comment)
But I was not able to respond to @FrogTheFrog on time.
sunshine logs.txt
Host Operating System
Windows
Operating System Version
Win 11 24H2 Build 26100.2894
Architecture
amd64/x86_64
Sunshine commit or version
Sunshine v2025.118.151840
Package
Windows - installer (recommended)
GPU Type
AMD
GPU Model
RTX 3080
GPU Driver/Mesa Version
566.36
Capture Method
None
Config
upnp = enabled display_mode_remapping = [{"type":"","received_resolution":"1680x1050","received_fps":"60","final_resolution":"2560x1600","final_refresh_rate":"60"},{"type":"","received_resolution":"1920x1080","received_fps":"60","final_resolution":"2560x1440","final_refresh_rate":"60"},{"type":"","received_resolution":"1920x1200","received_fps":"60","final_resolution":"2560x1600","final_refresh_rate":"60"},{"type":"","received_resolution":"1280x800","received_fps":"60","final_resolution":"2560x1600","final_refresh_rate":"60"},{"type":"","received_resolution":"","received_fps":"120","final_resolution":"2560x1440","final_refresh_rate":"120"},{"type":"","received_resolution":"3840x2160","received_fps":"60","final_resolution":"3840x2160","final_refresh_rate":"60"},{"type":"","received_resolution":"","received_fps":"","final_resolution":"","final_refresh_rate":""}] fps = [10,30,60,90,120,144] encoder = nvenc dd_mode_remapping = {"mixed":[{"requested_fps":"","final_refresh_rate":"","requested_resolution":"1920x1080","final_resolution":"3840x2160"},{"requested_fps":"","final_refresh_rate":"","requested_resolution":"3840x2160","final_resolution":"3840x2160"},{"requested_fps":"","final_refresh_rate":"","requested_resolution":"2560x1440","final_resolution":"3840x2160"},{"requested_fps":"","final_refresh_rate":"","requested_resolution":"1280x800","final_resolution":"2560x1600"},{"requested_fps":"","final_refresh_rate":"","requested_resolution":"1920x1200","final_resolution":"2560x1600"},{"requested_fps":"","final_refresh_rate":"","requested_resolution":"1680x1050","final_resolution":"2560x1600"}],"resolution_only":[{"requested_resolution":"3840x2160","final_resolution":"3840x2160"},{"requested_resolution":"2560x1440","final_resolution":"3840x2160"},{"requested_resolution":"","final_resolution":""}],"refresh_rate_only":[]} resolutions = [ 352x240, 480x360, 858x480, 1280x720, 1920x1080, 2560x1080, 3440x1440, 1920x1200, 3840x2160, 3840x1600, 2560x1440, 1680x1050, 2560x1600, 1600x900 ] address_family = both ping_timeout = 72000000 channels = 2 capture = ddx display_device_prep = ensure_only_display back_button_timeout = 2000Apps
Relevant log output
The text was updated successfully, but these errors were encountered: