Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extension point for optional wait operation before TriggerAfterPageChangeEventAsync is called (OSOE-972) #445

Open
sarahelsaig opened this issue Jan 16, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@sarahelsaig
Copy link
Member

sarahelsaig commented Jan 16, 2025

Sometimes frontend code immediately triggers an asynchronous fetch to get data after the page has loaded. One example is Lombiq.DataTables, where the data is delivered through a separate JSON-returning web request. To achieve the correct, repeatable behavior post-navigation events such as html-validate and Axe checks should only be called when this secondary loading has finished, so a page with useful content can be evaluated.

Unfortunately, there is no universal way to tell when is a site ready, so you'd want to write specific wait logic for each test that accommodates the frontend technologies used in that specific test. We should add some property to the configuration property (e.g. context.Configuration.Events.WaitAfterPageChange : Func<UITestContext, Task>) which can wait for the page state to indicate no loading.

Also implement such a wait for Lombiq.OSOCE.Tests.UI.Tests.ModuleTests.BehaviorDataTablesTests.RecipeDataShouldBeDisplayedCorrectly.

For more context see in Jira.

Jira issue

@github-actions github-actions bot changed the title Add an extension point for optional wait operation before TriggerAfterPageChangeEventAsync is called Add an extension point for optional wait operation before TriggerAfterPageChangeEventAsync is called (OSOE-972) Jan 16, 2025
@Piedone Piedone added the enhancement New feature or request label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants