Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Latest ComfyUI Commit looks like it's Stopped using Samplers.Py #235

Open
lord-lethris opened this issue Nov 1, 2023 · 5 comments
Open

Comments

@lord-lethris
Copy link

lord-lethris commented Nov 1, 2023

Getting an Error loading efficiency-nodes-comfyui

ImportError: cannot import name 'CompVisVDenoiser' from 'comfy.samplers' (D:\apps\SD-WebUI\ComfyUI\comfy\samplers.py)

Cannot import D:\apps\SD-WebUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui module for custom nodes: cannot import name 'CompVisVDenoiser' from 'comfy.samplers' (D:\apps\SD-WebUI\ComfyUI\comfy\samplers.py)

I "think" (fishing about for an answer) that ComfyUI no longer uses K_Sampler and Samplers.Py - Or at least the location where efficiency-nodes-comfyui looks for it?

image

image

I don't know if anyone can fix this - I think efficiency-nodes-comfyui is one of the most useful nodes in the scene...!

@xueqing0622
Copy link

same error:
Traceback (most recent call last):
File "F:\ComfyUI\ComfyUI\nodes.py", line 1735, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "F:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui_init
.py", line 1, in
from .efficiency_nodes import NODE_CLASS_MAPPINGS
File "F:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\efficiency_nodes.py", line 46, in
from .py import smZ_cfg_denoiser
File "F:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui\py\smZ_cfg_denoiser.py", line 7, in
from comfy.samplers import KSampler, CompVisVDenoiser, KSamplerX0Inpaint
ImportError: cannot import name 'CompVisVDenoiser' from 'comfy.samplers' (F:\ComfyUI\ComfyUI\comfy\samplers.py)

Cannot import F:\ComfyUI\ComfyUI\custom_nodes\efficiency-nodes-comfyui module for custom nodes: cannot import name 'CompVisVDenoiser' from 'comfy.samplers' (F:\ComfyUI\ComfyUI\comfy\samplers.py)

@HaydenReeve
Copy link

The author isn't maintaining this repo anymore, so someone will either have to submit a PR or make a fork.

@lord-lethris
Copy link
Author

It maybe being addressed here ->

jags111#10

@picobyte
Copy link

picobyte commented Nov 2, 2023

I posted a fix in the other thread.

@jags111
Copy link

jags111 commented Nov 3, 2023

okay looking into this and will update. Move same to my fork which takes care of the issues as of now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants