Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work as intended #1

Open
MilaMurry opened this issue Jan 1, 2024 · 5 comments
Open

Doesn't work as intended #1

MilaMurry opened this issue Jan 1, 2024 · 5 comments

Comments

@MilaMurry
Copy link

It seems it doesn't work as it intended to be.

Scenario 1
Go to your AMO, then close the tab, visit this link (farside), open the add-on, and you'll see there's a Mozilla cookie/localStorage in the list.

Scenario 2
Follow the scenario 1, close the browser, visit farside, open the add-on and you'll see the same thing.

I noticed it will only be triggered when I force stop the browser, reopen it and visit whatever website.

Well, I'm not sure when will it run either when a tab or browser closes, but I'd like to have both options in the settings. But don't delete just yet when multiple tabs still using the same domain.

Regardless, it would be better to have separate tabs for each category as cookies, localStorage, indexedDB and all.

Also please add these 2 words: localStorage and indexedDB in your add-on's description to make it clear. So the description may sound like this:

Deletes all cookies, localStorage and indexedDB from domains, not added to the provided whitelist, as soon as you exit your browser.

Last but not least, I'm using Iceraven browser if that makes it different.

@M-Reimer
Copy link
Owner

M-Reimer commented Jan 1, 2024

You have to close the browser to clear cookies. This is intended behavior. There are other Add-ons which work "by tab" but this approach was not very reliable in my tests.

You don't have to "force close". Just close the browser in the list of recently used apps (slide from the lower edge upwards).

Separate tabs would not work. The whitelist does not apply to localStorage and indexedDB.

As your description is wrong and just to make it clear: The whitelist is only applied to cookies. If you enable the deletion localStorage and indexedDB, then everything is deleted there! There is no other way to do it. Yes, I have to document this better and I will link some Mozilla bugs which are the reason for this limitations.

@MilaMurry
Copy link
Author

MilaMurry commented Jan 1, 2024

So the deletion of the localStorage and indexedDB isn't based on the whitelist? I thought so. I know that you can clear the localStorage by tab using localStorage.clear(), so it might work if it has that functionality.

And before I forget, other add-ons like CAD or Forget Me Not don't work properly, which is why I'm testing this add-on.

Unfortunately, closing and removing the app from recently used apps doesn't work either.

Well whatever the case, you can safely close this issue.

@M-Reimer
Copy link
Owner

M-Reimer commented Jan 2, 2024

Mozilla does not have API to apply a whitelist when cleaning localStorage or indexedDB. But mobile Firefox doesn't have any other way to clear them built in. So I added the checkbox. I would have printed the "all domains" in bold but my translation library does not support that currently.

Clearing localStorage by tab only works if the tab is still open and it is not reliable and impossible to check. Mozilla does not have API to tell if localStorage is in use or which domain uses it. So to be sure I decided clearing all could be a possible solution.

This, for sure, has disadvantages. I already have a report that you get logged out of Google accounts as they seem to store the session in localStorage. If this gets more common, this would render my Add-on useless. But at least for now I keep logged in where I want to.

I'll keep this issue open as a reminder that I still have to improve documentation including some links to the relevant bugs.

The big problem with Firefox Add-ons is that Add-on API seems to be at the very end of the Mozilla priority list. It is pretty common for bugs being open for years. So it's all about getting something done with what you have and find suitable workarounds for bugs in their API as you can never count on anything getting fixed in time.

@DB9-max
Copy link

DB9-max commented Feb 14, 2024

Works great in Firefox Android 👍👍👏

@MilaMurry
Copy link
Author

MilaMurry commented Feb 14, 2024

I don't think it actually deletes the real files. Recently Android reminded me that the browser was using too much storage and indeed it was. Luckily my device was rooted. I had to delete a bunch of folders (localStorage) like https+++github.com, https+++youtube.com, etc...

Of course this add-on works just fine, but like you said it's on Firefox's side. JFYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants