Image content size for shake listings #1280
Comments
spaceninja
added a commit
that referenced
this issue
Jan 25, 2025
This PR adjusts the layout of the shake page from the previous: total = sidebar + pad + content + pad 960 = 325 + 40 + 555 + 40 To the updated: total = sidebar + pad + content + pad 960 = 330 + 40 + 550 + 40 This better reflects our image intrinsic width of 550 from the CDN. Fixes #1280
spaceninja
added a commit
that referenced
this issue
Jan 25, 2025
This PR adjusts the layout of the shake page from the previous: total = sidebar + pad + content + pad 960 = 325 + 40 + 555 + 40 To the updated: total = sidebar + pad + content + pad 960 = 330 + 40 + 550 + 40 This better reflects our image intrinsic width of 550 from the CDN. Fixes #1280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #1278, shake pages also have some minor size issues.
This is visible for any shake listing, like the friend shake, or the Incoming page, etc.. For these pages, the sidebar is on the left.
At the widest layout, the image area is 554px instead of 550px.
The sidebar is 325px, not 330px like it is for permalink pages. Second, there is 1px of padding applied here:
Once those are adjusted, the image width is 550px. To my eye there are no negative issues introduced.
The text was updated successfully, but these errors were encountered: