You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently the function onCombatStarted() is not called for armor upgrades. This is because they are hidden inside the armor.nut they are attached to and the armor.nut needs to pass that event on. But unlike many other events, this is not passed on in Vanilla.
To Reproduce
Hook an armor upgrade or create a new armor upgrade and utilize their function onCombatStarted(), e.g. by printing an error message.
Add that upgrade to your invenotory, use it and start a battle
The log is not printed
Expected behavior onCombatStarted() is called so it can be used for armor upgrades. For example by adding a dummy effect at combat start which implements the effect of that attachement.
Screenshots
Example implementation:
The text was updated successfully, but these errors were encountered:
Versions
Describe the bug
Currently the
function onCombatStarted()
is not called for armor upgrades. This is because they are hidden inside the armor.nut they are attached to and thearmor.nut
needs to pass that event on. But unlike many other events, this is not passed on in Vanilla.To Reproduce
function onCombatStarted()
, e.g. by printing an error message.Expected behavior
onCombatStarted()
is called so it can be used for armor upgrades. For example by adding a dummy effect at combat start which implements the effect of that attachement.Screenshots
Example implementation:
The text was updated successfully, but these errors were encountered: