Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Storage Consumers Report: Total Used Disk space is not accurate #98

Closed
tjyang opened this issue Aug 14, 2017 · 21 comments
Closed

Top Storage Consumers Report: Total Used Disk space is not accurate #98

tjyang opened this issue Aug 14, 2017 · 21 comments
Assignees

Comments

@tjyang
Copy link

tjyang commented Aug 14, 2017

I have VM instance in miq version fine-3

  • Ex1: Both used and provision are listed as 8.7TB.

image

  • another place in miq to show ex1 VM's disk usage

image

  • Ex1: in vcenter the total used disk space is 7.12TB, not 8.7TB(8.65TB).

image

  • Ex2: miq report showing both are used and provisioned are at 4TB.
    image

  • Ex2: while from vcenter GUI, Used storage is only 1.76TB

image

@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Feb 19, 2018
@tjyang
Copy link
Author

tjyang commented Feb 19, 2018

I will check against Gapri-1 release to see if disk usage report is still not correct.

@agrare
Copy link
Member

agrare commented Nov 26, 2018

I think the issue here is that the :used_storage for a VM ends up using the disks' size_on_disk property and we can't get the actual used storage per disk from the VIM SDK. We can only get this per datastore at the VM level.

It would be possible to add vm-level used storage and override this core used_disk_storage method for vmware.

@agrare agrare removed the stale label Nov 26, 2018
@agrare agrare self-assigned this Nov 26, 2018
@tjyang
Copy link
Author

tjyang commented Nov 26, 2018 via email

@paltaa
Copy link

paltaa commented Feb 15, 2019

Have this been fixed? or a workaround?

@agrare
Copy link
Member

agrare commented Feb 19, 2019

@paltaa I think smartstate might be able to get this data but we cannot get it from refresh, maybe @roliveri or @hsong-rh can help

@tjyang
Copy link
Author

tjyang commented Feb 19, 2019

@paltaa , I reported this issue for vCenter provider.

@tjyang
Copy link
Author

tjyang commented Feb 19, 2019

Hi All

I did another verification on this issue.

So this issue can be closed. VMWare VM actual space usage reported once it is scanned by smart analysis.
@paltaa , can you confirm and close this issue ?

@agrare
Copy link
Member

agrare commented Feb 19, 2019

Thanks @tjyang !

Yeah it should be more obvious that smartstate is required for these, we had issues with this recently with the snapshot size as well.

@tjyang
Copy link
Author

tjyang commented Feb 19, 2019

@agrare , I think this issue happened even the VM got scanned by S.A. in earlier versions of MIQ.

@paltaa
Copy link

paltaa commented Feb 19, 2019

@tjyang Will test and confirm, thanks alot

@paltaa
Copy link

paltaa commented Feb 19, 2019

@tjyang Okay, so it was in fact a smart analysis problem, but since it creates snapshots of the VM's to get the analysis and the real disk usage, this creates a downtime of a few seconds that we cannot afford, so is there any other way we could get those metrics, or point me in the right direction to do it in the manageiq enviroment?

@agrare
Copy link
Member

agrare commented Feb 19, 2019

@paltaa we are unable to get file sizes from the VIM API which is used for refresh to smartstate is the only way to get this data.

@agrare agrare closed this as completed Feb 19, 2019
@tjyang
Copy link
Author

tjyang commented Feb 19, 2019

@paltaa ,

I don't believe the snapshot will be a few seconds long in a production VMWare setting that has hight end (flash) storage systems. I know netbackup/rubrik for VMWare are using snapshots for backup purpose. Unless your VM has very very high I/O otherwise taking snapshot should be fine. You can try S.A. on less busy VM first.

Also looks like you are using miq to manage production environment which is not recommended by miq team ;).

Also I voiced in another ticket that S.A. should not rely only on snapshot approach to gather system information. a simple ansible/ssh login shell script can collect most of the system info. Another point is that miq is is now managing phyiscal machines also.(no way to take snapshot).

Hope your question can be addressed by manageiq team members.

@agrare
Copy link
Member

agrare commented Feb 19, 2019

@tjyang @paltaa I don't see why we couldn't use datastore smartstate to get the file sizes since that uses the datastore browser, this would be a worthwhile RFE.

That would remove the need to use VM smartstate.

@paltaa
Copy link

paltaa commented Feb 19, 2019

@tjyang Thats the point, dont see the necesity to do a disk usage analysis by taking a snapshot if a small ansible playbook could get the metrics and return them to manageiq or any other system.

@tjyang
Copy link
Author

tjyang commented Feb 19, 2019

@agrare

Do you want me to open up a RFE on S.A. without snaptshot action on providers ?

@paltaa
Copy link

paltaa commented Feb 19, 2019

@tjyang It would be nice, also is there a url to join that discussion/follow the thread or contribute to that solution

@agrare
Copy link
Member

agrare commented Feb 19, 2019

@paltaa well we wouldn't use an ansible playbook because we already have an efficient connection broker so we'd save sessions on your VC by not using ansible :)

@tjyang Yes I think that would be a good enhancement request, the description would be "Acquire disk usage with datastore smartstate not vm smartstate". It isn't going to be easy and will require a good bit of refactoring but there is a workaround.

Also @paltaa taking a snapshot for smartstate should not create "a few seconds of downtime". The only "downtime" is a momentary stun/unstun when coalescing the last of the writes into the base disk. If that takes longer than a tenth of a second there is something wrong. Snapshots are used on production VMs all the time, this is not unique to manageiq.

@tjyang
Copy link
Author

tjyang commented Feb 19, 2019

@agrare, pls see HOW.3 at ManageIQ/manageiq-smartstate#84,
Let me know if you want me to have it as standalone ticket.

@agrare
Copy link
Member

agrare commented Feb 20, 2019

Hey @tjyang, I think this is a different issue because manageiq-smartstate is for scanning VM disk images where datastore smartstate uses the datastore browser.

I opened #374 to track this request.

agrare pushed a commit to agrare/manageiq-providers-vmware that referenced this issue Apr 15, 2019
…tring

Changed ${/#ae_reason} to a string value in on_error methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants