From ec335fdc23d4e9bf372f1b8443a1277aa652fb46 Mon Sep 17 00:00:00 2001 From: Keenan Brock Date: Wed, 16 Oct 2024 18:05:21 -0400 Subject: [PATCH] Remove non-existing parent factory references These factories were added: https://github.com/ManageIQ/manageiq/pull/22316 But were removed: https://github.com/ManageIQ/manageiq/pull/22503 They were basically NO-OP factories, so removing is no big deal For some reason, older versions of FactoryBot were ok with a bad reference (probably because the klass was overridden anyway) But newer versions of FactoryBot complained --- spec/factories/workflow.rb | 2 +- spec/factories/workflow_instance.rb | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/spec/factories/workflow.rb b/spec/factories/workflow.rb index 5e34ae3..af6f7e8 100644 --- a/spec/factories/workflow.rb +++ b/spec/factories/workflow.rb @@ -1,3 +1,3 @@ FactoryBot.define do - factory :workflows_automation_workflow, :class => "ManageIQ::Providers::Workflows::AutomationManager::Workflow", :parent => :workflow + factory :workflows_automation_workflow, :class => "ManageIQ::Providers::Workflows::AutomationManager::Workflow" end diff --git a/spec/factories/workflow_instance.rb b/spec/factories/workflow_instance.rb index c327f98..73d8df0 100644 --- a/spec/factories/workflow_instance.rb +++ b/spec/factories/workflow_instance.rb @@ -1,5 +1,6 @@ FactoryBot.define do - factory :workflows_automation_workflow_instance, :class => "ManageIQ::Providers::Workflows::AutomationManager::Workflow_instance", :parent => :workflow_instance do + factory :workflows_automation_workflow_instance, :class => "ManageIQ::Providers::Workflows::AutomationManager::Workflow_instance" do + status { "pending" } manager_ref { SecureRandom.uuid } end end