Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form conversion: Services Set Retirement #6845

Closed
himdel opened this issue Apr 3, 2020 · 1 comment · Fixed by #7518
Closed

Form conversion: Services Set Retirement #6845

himdel opened this issue Apr 3, 2020 · 1 comment · Fixed by #7518

Comments

@himdel
Copy link
Contributor

himdel commented Apr 3, 2020

Convert form to use DDF/React and API - parent issue #6825

Location: Services -> My Services (select 1+) -> Lifecycle -> Set Retirement Date
Form: Set Retirement

current type: Angular
API state:
Need info

PM Input: 2 - Medium

imported status: NOT ASSIGNED

@skateman
Copy link
Member

skateman commented Oct 6, 2020

@Maria-Cordero-ibm do you think you can handle this? The current implementation is rendered in the app/views/shared/views/_retire.html.haml and it should be replaced there with a React component. API seems to be fully implemented, there's a request_retire API endpoint that should just work.

You could also replace the immediate retiring to be API driven by calling the retire when clicking on the other button under Lifecycle. This should probably be done in a separate PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment