Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form conversion: Compute/Physical infrastructure/ Providers change password #6856

Closed
himdel opened this issue Apr 3, 2020 · 11 comments · Fixed by #7589
Closed

Form conversion: Compute/Physical infrastructure/ Providers change password #6856

himdel opened this issue Apr 3, 2020 · 11 comments · Fixed by #7589

Comments

@himdel
Copy link
Contributor

himdel commented Apr 3, 2020

Convert form to use DDF/React and API - parent issue #6825

Location: Compute/Physical infrastrucute/ Providers
Form: change password

current type: Angular
API state:
Need info

PM Input: 2 - Medium

imported status: NOT ASSIGNED

@skateman
Copy link
Member

skateman commented Oct 6, 2020

Screenshot from 2020-10-06 10-04-43
Screenshot from 2020-10-06 10-05-06

@agrare does this form even make sense? I think it could be deleted and we can just edit the provider and change the password there.

@miq-bot add_label question

@chessbyte
Copy link
Member

I wonder if this goes out and resets the password on the target. A standard Change Password form is probably good to have in our arsenal that we can re-use all over. /cc @Fryguy

@skateman
Copy link
Member

skateman commented Oct 6, 2020

@chessbyte this one expects the current password, meanwhile the edit provider doesn't. Theres also validation on the edit provider and here it just asks for the password twice, so it's a nice place to mess up the provider credentials ...

@chessbyte chessbyte changed the title Form conversion: Compute/Physical infrastrucute/ Providers change password Form conversion: Compute/Physical infrastructure/ Providers change password Oct 6, 2020
@agrare
Copy link
Member

agrare commented Oct 12, 2020

@skateman this is an ems_operation that changes the password of the target provider, not just the password in our database.

@Fryguy
Copy link
Member

Fryguy commented Oct 12, 2020

A standard Change Password form is probably good to have in our arsenal that we can re-use all over.

Agreed on a component that is common.

this is an ems_operation that changes the password of the target provider, not just the password in our database.

We don't do this for any other provider...should we do it here?

@agrare
Copy link
Member

agrare commented Oct 12, 2020

We don't do this for any other provider...should we do it here?

Not sure what you mean, should we support this operation for the Lenovo provider? They added it as a feature so I think so yes

@Fryguy
Copy link
Member

Fryguy commented Oct 12, 2020

Yeah, I'm wondering if we should remove that feature from the Lenovo plugin since they are the only group that implemented it? Or should we add that as a future-feature to all of the other plugins?

@skateman
Copy link
Member

Any update on this?

@chessbyte
Copy link
Member

@agrare Do you know if users have an alternative way of changing password on the target provider? If so, I would suggest we drop this feature. cc @Fryguy

@agrare
Copy link
Member

agrare commented Jan 18, 2021

Yes they can still change the password natively on the xclarity management UI

@skateman
Copy link
Member

There's also a wrongly named RBAC feature (ems_infra_change_password) and an API action for this, should those go as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants